Skip to content

[release/0.4] Fix issue #569 remove BaseURL - #580

Merged
awmirantis merged 1 commit into
Mirantis:release/0.4from
awmirantis:backport-issue-569-release-0.4
Oct 8, 2026
Merged

awmirantis merged 1 commit into
Mirantis:release/0.4from
awmirantis:backport-issue-569-release-0.4

Conversation

@awmirantis

Copy link
Copy Markdown
Contributor

(cherry picked from commit 3949332)

Fixes #569

Proposed Changes

BaseURL is left nil so streaming.NewServer fills in the correct
scheme and host.

@awmirantis
awmirantis requested a review from a team October 7, 2026 19:41
(cherry picked from commit 3949332)
@awmirantis
awmirantis force-pushed the backport-issue-569-release-0.4 branch from 36e054f to c22041c Compare October 7, 2026 19:58
@awmirantis awmirantis changed the title Fix issue #569 remove BaseURL [release/0.4] Fix issue #569 remove BaseURL Oct 7, 2026

@athongsamai athongsamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sgajlekar-spec sgajlekar-spec left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@awmirantis
awmirantis merged commit daa976a into Mirantis:release/0.4 Oct 8, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants