Fix release workflow tag validation#10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
workflow_dispatchref was checked out before validation, allowing a malicious checked-outscripts/validate-version-tag.shto forge step outputs and enable publishing attacker-controlled artifacts.Description
tag_name,version, andis_prereleaseoutputs.actions/checkoutusages for release flows to explicitly check outrefs/tags/<tag>instead of the original user-supplied ref.tag_commitin thevalidatejob and add verification steps that ensure downstreamtest,build-otp, andgithub-releasejobs verify both the tag resolution and the checked-outHEADmatch the previously validated commit.Testing
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml")'and it parsed successfully.bash -n scripts/validate-version-tag.shand it passed syntactic checks.git diff --checkand there are no whitespace/patch errors.mix format --check-formattedandmix testcould not be executed in this environment because Hex installation failed when attempting to download metadata (network/Hex access returned HTTP 403).Codex Task