Harden Docker distributed Erlang startup#3
Merged
homerquan merged 1 commit intoMay 18, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
EXPOSE 4369 9000-9010and keep only the application gRPC port exposed (50051).CMDrequire a non-empty, non-defaultMN_COOKIEwhenMN_NODE_NAMEenables distributed Erlang and exit with a clear error if the cookie is unset or stillmirrorneuron.MN_COOKIEentry in theREADME.mdto note thatmirrorneuronis only a local-development default and that operators must set a strong cookie before enabling distributed Erlang or running in production.Testing
mix format, which completed successfully.MN_NODE_NAMEis set butMN_COOKIEis empty or the defaultmirrorneuronby executing the image startup command in-shell and checking for the expected error string, which succeeded.mix testcould not be run in this environment becausemix local.hex --forcefailed to fetch Hex metadata (network/registry error), so test-suite execution was not completed here.Codex Task