Require admin token for ClearJobs RPC#4
Merged
homerquan merged 1 commit intoMay 18, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ClearJobsgRPC method exposed a destructive, unauthenticated bulk-delete of terminal job records; this change prevents network-reachable clients from invoking the deletion without an explicit administrative credential.Description
admin_tokenfield to theClearJobsRequestprotobuf contract and to the generated Elixir protobuf module so requests can carry a confirmation token (proto/job.proto,lib/mirror_neuron_grpc/job.pb.ex).MIRROR_NEURON_GRPC_ADMIN_TOKENenvironment value before calling the destructiveMirrorNeuron.Monitor.clear_jobs/0, and returnpermission_deniedfor unauthenticated requests (lib/mirror_neuron_grpc/server.ex).ClearJobscalls are rejected prior to any deletion (tests/unit/grpc_job_server_test.exs).README.md.Testing
mix formatsuccessfully to ensure formatting compliance.tests/unit/grpc_job_server_test.exsthat asserts unauthenticatedClearJobsrequests raise aGRPC.RPCErrorwith the permission message, but runningmix testwas blocked in this environment due to inability to fetch Hex/dependencies (network/CONNECT tunnel 403), so automated test execution could not be completed here.Codex Task