Harden recovery bundle path loading#8
Merged
homerquan merged 1 commit intoMay 18, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
manifest_ref.job_pathvalues were being passed toJobBundle.load/1, which treats non-existent paths as inline JSON and can cause untrusted Redis data to be interpreted as executable manifests.Description
JobBundle.load_filesystem_path/1API that only accepts real filesystem bundle directories (or returns explicit errors) and does not attempt to decode inline JSON.lib/mirror_neuron/cluster/leader.ex) and local startup recovery (lib/mirror_neuron/runtime/local_recovery.ex) to useJobBundle.load_filesystem_path/1formanifest_ref.job_pathvalues loaded from Redis.tests/unit/job_bundle_test.exsto verify thatload_filesystem_path/1rejects inline JSON strings and still accepts valid bundle directories while leavingJobBundle.load/1behavior unchanged for map/inline manifest inputs.Testing
mix format --check-formatted, which completed successfully.tests/unit/job_bundle_test.exsexercising the newload_filesystem_path/1behavior.mix test tests/unit/job_bundle_test.exsandmix deps.get, but running the test suite was blocked by the environment being unable to fetch Hex dependencies (HTTP 403), so the new tests could not be executed in this environment.Codex Task