feat(wallet): add home ad banners#6466
Open
SeniorZhai wants to merge 14 commits into
Open
Conversation
SeniorZhai
force-pushed
the
feat/wallet-home-ad-banner
branch
from
38a3e40 to
acf2935
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for dynamic “home ad banners” on the wallet home screens by fetching banner configs from the referral service, rendering them in the existing banner pager, tracking interactions, and persisting dismissals.
Changes:
- Introduces
WalletHomeBanner/WalletHomeBannerActionmodels plus filtering (visibleWalletHomeBanners) and stores closed banner IDs in preferences. - Fetches wallet home banners via
ReferralService/ReferralRepository, wires them intoWalletHomeState, and renders dynamic banner pages in Compose. - Adds/extends tests covering banner visibility, priority filtering, and referral service endpoint/query behavior.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/test/java/one/mixin/android/ui/wallet/home/WalletHomeBuilderTest.kt | Adds tests ensuring banner card visibility when dynamic banners exist / are closed / are prioritized. |
| app/src/test/java/one/mixin/android/api/service/ReferralServiceTest.kt | New reflection-based test validating referral banners endpoint and lang query usage. |
| app/src/main/java/one/mixin/android/util/analytics/AnalyticsTracker.kt | Adds tracking helper and source constants for wallet home ad banner interactions. |
| app/src/main/java/one/mixin/android/ui/wallet/WalletViewModel.kt | Exposes walletHomeBanners() via ReferralRepository. |
| app/src/main/java/one/mixin/android/ui/wallet/WalletHomePrivacyFragment.kt | Fetches, filters, renders, tracks, and persists dismissal of dynamic banners. |
| app/src/main/java/one/mixin/android/ui/wallet/WalletHomePreferences.kt | Adds preference key for closed dynamic banner IDs. |
| app/src/main/java/one/mixin/android/ui/wallet/WalletHomeClassicFragment.kt | Mirrors privacy fragment behavior for dynamic banners in classic wallet home. |
| app/src/main/java/one/mixin/android/ui/wallet/WalletFragment.kt | Triggers banner refresh as part of wallet update flow. |
| app/src/main/java/one/mixin/android/ui/wallet/home/WalletHomeState.kt | Extends state/callbacks to carry dynamic banners and banner interactions. |
| app/src/main/java/one/mixin/android/ui/wallet/home/components/BannerCards.kt | Renders dynamic banner pages (icon/title/description/actions) in the pager and supports closing them. |
| app/src/main/java/one/mixin/android/ui/setting/LogAndDebugFragment.kt | Includes new preference key in debug/diagnostic preference list. |
| app/src/main/java/one/mixin/android/ui/home/web3/Web3ViewModel.kt | Exposes walletHomeBanners() via ReferralRepository for classic/web3 wallet flows. |
| app/src/main/java/one/mixin/android/repository/ReferralRepository.kt | Implements banner fetch with bot session warm-up and error handling. |
| app/src/main/java/one/mixin/android/Constants.kt | Minor formatting change around referral constants. |
| app/src/main/java/one/mixin/android/api/service/ReferralService.kt | Adds app-banners endpoint + lang query helper. |
| app/src/main/java/one/mixin/android/api/response/WalletHomeBanner.kt | New banner models + filtering/sorting helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SeniorZhai
force-pushed
the
feat/wallet-home-ad-banner
branch
10 times, most recently
from
4f91c1c to
1f0f377
Compare
SeniorZhai
force-pushed
the
feat/wallet-home-ad-banner
branch
from
1f0f377 to
87eff1d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
app/src/main/java/one/mixin/android/api/service/ReferralService.kt:21
walletHomeBannerLang()concatenateslanguage + "-" + country, which can yield invalid values likeen-ifcountryis empty. PreferLocale#toLanguageTag()to generate a valid BCP 47 language tag.
Comment on lines
532
to
535
| val b = sourceRequest.newBuilder() | ||
| b.addHeader("User-Agent", API_UA) | ||
| .addHeader("Accept-Language", Locale.getDefault().language) | ||
| .addHeader("Accept-Language", Locale.getDefault().language + "-" + Locale.getDefault().country) | ||
| .addHeader("Mixin-Device-Id", getStringDeviceId(resolver)) |
Comment on lines
+201
to
+207
| Row( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(top = 22.dp, end = 22.dp, bottom = bottomPadding) | ||
| .clickable { onClick(banner) }, | ||
| verticalAlignment = Alignment.Top, | ||
| ) { |
SeniorZhai
force-pushed
the
feat/wallet-home-ad-banner
branch
from
ecf05d7 to
d91cbd4
Compare
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
…-banner # Conflicts: # app/src/main/java/one/mixin/android/ui/wallet/WalletFragment.kt # app/src/main/java/one/mixin/android/ui/wallet/WalletHomePrivacyFragment.kt
Contributor
Merge conflicts resolved in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.