Evaluate retention and MemWAL enrollment gates#366
Merged
Conversation
| crates/omnigraph/src/storage.rs) run_rustfs_ci=true ;; | ||
| crates/omnigraph/src/db/manifest.rs|crates/omnigraph/src/db/manifest/*) run_rustfs_ci=true ;; | ||
| crates/omnigraph/tests/s3_storage.rs|crates/omnigraph/tests/write_cost_s3.rs|crates/omnigraph/tests/lance_surface_guards.rs|crates/omnigraph/tests/helpers/*) run_rustfs_ci=true ;; | ||
| crates/omnigraph/tests/s3_storage.rs|crates/omnigraph/tests/write_cost_s3.rs|crates/omnigraph/tests/lance_surface_guards.rs|crates/omnigraph/tests/memwal_enrollment_gate.rs|crates/omnigraph/tests/helpers/*) run_rustfs_ci=true ;; |
There was a problem hiding this comment.
A pull request that changes only checkpoint_retention_cost.rs does not enable the RustFS job, and that job has no command for s3_checkpoint_retention_matrix_is_exact_and_records_the_current_no_go even when another file enables it. The S3 test then skips outside a configured RustFS environment, so broken or vacuous retention evidence can merge without being exercised.
Context Used: AGENTS.md (source)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decision
RFC-024 and RFC-025 remain research-blocked on their current access shapes.
RFC-026 Gate E0 passes only for the bounded main-branch, unsharded, single-live-writer-process profile. This clears Phase A foundation work from the upstream release calendar, while an upstream receipt/seal API remains required for broader overlapping-process topology.
This PR is production-neutral: internal schema stays v6, and it adds no durable-head/checkpoint/stream rows, public APIs, stream acknowledgements, folds, or production writer path.
Validation
cargo test --workspace --lockedscripts/check-agents-md.shgit diff --checkGreptile Summary
This PR adds research gates for checkpoint retention and MemWAL enrollment. The main changes are:
Confidence Score: 4/5
The checkpoint-retention S3 gate needs CI wiring before merging.
.github/workflows/ci.yml
Important Files Changed
Reviews (1): Last reviewed commit: "Evaluate retention and MemWAL enrollment..." | Re-trigger Greptile
Context used: