Implement RFC-026 Phase A MemWAL foundation#368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
RFC-022 made the direct-publish path correct, but streaming cannot safely begin with row admission. We first need durable lifecycle ownership, exact crash classification, and one admission/exclusion order shared by every physical writer. This slice establishes that correctness and format foundation using Lance MemWAL rather than introducing a custom WAL or transaction manager.
Deliberate boundary
This does not expose public stream enrollment,
@stream, WAL rowput, durable row acknowledgement, fold, drain/resume, or fresh-read behavior. The supported Phase-A topology is canonical main, one empty unsharded shard, and one live writer process.Validation
cargo test --workspace --lockedcargo test -p omnigraph-engine --features failpoints --test failpoints --locked— 140 passed, 1 intentional helper ignoredscripts/check-agents-md.shgit diff --checkGreptile Summary
This PR adds the RFC-026 Phase A MemWAL foundation. The main changes are:
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix: preserve stream enrollment success ..." | Re-trigger Greptile
Context used: