Merge pull request phpmyadmin#20122 from thomasvincent/fix/serverrequest-search-controller

fix: migrate $_REQUEST to ServerRequest in SearchController

Author: MauricioFauth

phpstan-baseline.neon

@@ -1608,12 +1608,6 @@ parameters:
 			count: 1
 			path: src/Controllers/Database/RoutinesController.php
 
-		-
-			message: '#^Construct empty\(\) is not allowed\. Use more strict comparison\.$#'
-			identifier: empty.notAllowed
-			count: 1
-			path: src/Controllers/Database/SearchController.php
-
 		-
 			message: '#^Parameter \#1 \$database of method PhpMyAdmin\\Database\\CentralColumns\:\:deleteColumnsFromList\(\) expects string, mixed given\.$#'
 			identifier: argument.type

psalm-baseline.xml

@@ -926,9 +926,6 @@
     <PossiblyUnusedMethod>
       <code><![CDATA[__construct]]></code>
     </PossiblyUnusedMethod>
-    <RiskyTruthyFalsyComparison>
-      <code><![CDATA[empty($_REQUEST['ajax_page_request'])]]></code>
-    </RiskyTruthyFalsyComparison>
   </file>
   <file src="src/Controllers/Database/SqlAutoCompleteController.php">
     <PossiblyUnusedMethod>

src/Controllers/Database/SearchController.php

@@ -90,7 +90,7 @@ public function __invoke(ServerRequest $request): Response
         }
 
         // If we are in an Ajax request, we need to exit after displaying all the HTML
-        if ($request->isAjax() && empty($_REQUEST['ajax_page_request'])) {
+        if ($request->isAjax() && ! $request->has('ajax_page_request')) {
             return $this->response->response();
         }