Skip to content

CI builds: add all files needed for flashing in the zip file for download (incl. bootloader.bin, partitions.bin, boot_app0.bin)#347

Draft
Copilot wants to merge 4 commits intomdevfrom
copilot/update-ci-build-script
Draft

CI builds: add all files needed for flashing in the zip file for download (incl. bootloader.bin, partitions.bin, boot_app0.bin)#347
Copilot wants to merge 4 commits intomdevfrom
copilot/update-ci-build-script

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 18, 2026

FRAMEWORK_DIR is not exposed as a SCons env variable in post-build scripts — it's internal to the platform builder. The previous fix always resolved to "", so boot_app0.bin was never copied and remained absent from CI artifact zips.

Changes

  • pio-scripts/output_bins.py: Replace env.get("FRAMEWORK_DIR", "") with env.PioPlatform().get_package_dir("framework-arduinoespressif32") — the correct PlatformIO API, consistent with how obj-dump.py already resolves platform paths. ESP8266 builds return None from get_package_dir() and are silently skipped; old arduino-esp32 1.0.x (no tools/partitions/boot_app0.bin) is skipped by the isfile() guard.
_ARDUINO_ESP32_PACKAGE = "framework-arduinoespressif32"
try:
    framework_dir = env.PioPlatform().get_package_dir(_ARDUINO_ESP32_PACKAGE)
    if framework_dir:
        boot_app0_src = os.path.join(str(framework_dir), "tools", "partitions", "boot_app0.bin")
        if os.path.isfile(boot_app0_src):
            shutil.copy(boot_app0_src, os.path.join(builddir, "boot_app0.bin"))
except Exception as e:
    print(f"Warning: could not copy boot_app0.bin ({e})")
  • .github/workflows/build.yml: Updated stale comment to reflect the platform API approach.

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…ware artifact zips

Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
Copilot AI changed the title [WIP] Update GitHub CI build script to include additional binaries CI: bundle partitions.bin, bootloader.bin, and boot_app0.bin into firmware artifact zips Mar 18, 2026
Copilot AI requested a review from softhack007 March 18, 2026 15:04
Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
…Cons env variable

Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
Copilot AI changed the title CI: bundle partitions.bin, bootloader.bin, and boot_app0.bin into firmware artifact zips fix: use PlatformIO platform API to locate boot_app0.bin Mar 18, 2026
@softhack007 softhack007 changed the title fix: use PlatformIO platform API to locate boot_app0.bin CI builds: add all files needed for flashing in the zip file for download (incl. bootloader.bin, partitions.bin, boot_app0.bin) Mar 24, 2026
@softhack007
Copy link
Copy Markdown
Collaborator

@coderabbitai review please :-)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 4, 2026

@softhack007 Sure! I'll kick off a review of the PR right away.


🧠 Learnings used
Learnt from: softhack007
Repo: MoonModules/WLED-MM PR: 0
File: :0-0
Timestamp: 2026-01-27T00:51:23.865Z
Learning: For Wokwi ESP32 simulations with PlatformIO, bootloader.bin, partitions.bin, and firmware.bin must be merged into a single flash image using `esptool.py merge_bin` with offsets 0x1000, 0x8000, and 0x10000 respectively. Wokwi does not support loading multiple flash file segments separately via wokwi.toml configuration.
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 4, 2026

Warning

Rate limit exceeded

@softhack007 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 35 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 35 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ea52a10a-b220-48fe-b832-7d3541384b77

📥 Commits

Reviewing files that changed from the base of the PR and between 1f92ac1 and 65ef006.

📒 Files selected for processing (4)
  • .github/workflows/build.yml
  • .github/workflows/nightly.yml
  • .github/workflows/release.yml
  • pio-scripts/output_bins.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copilot/update-ci-build-script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants