Conversation
…ware artifact zips Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
…Cons env variable Co-authored-by: softhack007 <91616163+softhack007@users.noreply.github.com>
|
@coderabbitai review please :-) |
|
🧠 Learnings used✅ Actions performedReview triggered.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 35 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FRAMEWORK_DIRis not exposed as a SCons env variable in post-build scripts — it's internal to the platform builder. The previous fix always resolved to"", soboot_app0.binwas never copied and remained absent from CI artifact zips.Changes
pio-scripts/output_bins.py: Replaceenv.get("FRAMEWORK_DIR", "")withenv.PioPlatform().get_package_dir("framework-arduinoespressif32")— the correct PlatformIO API, consistent with howobj-dump.pyalready resolves platform paths. ESP8266 builds returnNonefromget_package_dir()and are silently skipped; old arduino-esp32 1.0.x (notools/partitions/boot_app0.bin) is skipped by theisfile()guard..github/workflows/build.yml: Updated stale comment to reflect the platform API approach.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.