fix(agent-core): relax directory skill frontmatter requirements to prevent silent skipping#657
Open
puppylpg wants to merge 1 commit into
Open
fix(agent-core): relax directory skill frontmatter requirements to prevent silent skipping#657puppylpg wants to merge 1 commit into
puppylpg wants to merge 1 commit into
Conversation
…event silent skipping
🦋 Changeset detectedLatest commit: b38908c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #580
Problem
Kimi Code CLI creates a vicious cycle: the system prompt template does not explain the
SKILL.mdformat, so the agent writes invalid skills for users, which are then silently discarded by the parser.Root cause
packages/agent-core/src/skill/parser.tsenforced two strict checks on directory skills:---).nameanddescription.If either check fails, a
SkillParseErroris thrown and caught inscanner.ts, where it is logged as a warning and the skill is skipped entirely. Users receive no visible feedback that their skills were ignored.This is especially problematic because the code already contains fallback logic (
name ?? skillDirName,description ?? firstBodyLine) that was unreachable due to the earlythrow.Secondary cause
The system prompt template (
system.md) does not mention frontmatter, required fields, or the directory-vs-flat distinction, so agents helping users write skills have no authoritative source for the correct format.What changed
parser.ts: Removed the strict frontmattername/descriptionrequirements for directory skills. The existing fallback logic now works as intended: missingnamefalls back to the directory name, missingdescriptionfalls back to the first non-empty body line.system.md: Added a "Skill format" section to the system prompt template that explains the optional YAML frontmatter block and its fields, so agents can author valid skills for users.scanner.test.ts: Updated the test that previously asserted skills were skipped; it now verifies the fallback behavior..changeset/relax-skill-frontmatter-requirements.mdwithpatchbumps for both@moonshot-ai/agent-coreand@moonshot-ai/kimi-code.Checklist
gen-changesetsskill.