feat(providers): sync custom registry providers on startup refresh#675
Merged
Conversation
🦋 Changeset detectedLatest commit: 4335c78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c878224fa6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- group registry providers by URL and retry available API keys\n- automatically add new providers and remove disappeared ones\n- coalesce duplicate source URLs to avoid false config-change reports\n- clear defaultThinking when default model is removed\n- update docs and add tests for registry sync scenarios
Skip removed / metadata-only provider updates when reporting model list changes.\n\n add: test to enforce the behavior.
sailist
force-pushed
the
fix/provider-refresh
branch
from
c878224 to
4335c78
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the startup provider refresh logic to properly synchronize custom registry providers. Previously, registry providers were not fully synced during startup refresh, which could leave stale entries, create duplicates, or fail to surface newly available providers. The change groups providers by registry URL, handles API key rotation, and ensures the provider list accurately reflects the current registry state.
1. Custom registry provider synchronization on startup refresh
Problem:
When custom registry providers were configured, the startup refresh did not reliably sync them. Duplicate source URLs could trigger false config-change reports, disappeared providers were not removed, and newly available providers were not automatically added. Additionally, if the default model was removed,
defaultThinkingwas left pointing to a stale value.What was done:
defaultThinkingwhen the default model is removed.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.