fix(docker): bump builder to rust:1.90 to satisfy dep MSRV#31
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7dfbbe01ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,4 +1,4 @@ | |||
| FROM rust:1.83 as builder | |||
| FROM rust:1.90 as builder | |||
There was a problem hiding this comment.
Keep builder and runtime on same Debian release
On the Fly deploy path I checked (fly.toml builds this Dockerfile), rust:1.90 now resolves to the Trixie-based Rust image while the final stage remains debian:bookworm-slim. Because the release binary is dynamically linked against the builder's libc/OpenSSL stack and then copied into an older Bookworm runtime, deploys can build successfully but fail at container start with missing/newer symbol versions. Pin the builder to the matching suite, e.g. rust:1.90-bookworm, or move the runtime stage to Trixie as well.
Useful? React with 👍 / 👎.
Summary
rust:1.83, but recent transitive deps require newer rustc:getrandom 0.4.2needsedition2024(Cargo 1.85+) andtime 0.3.47requires rustc 1.88+. Production deploys were failing oncargo build --releaseinside the image.rust:1.90, which clears both MSRV bumps with margin and stays below CI'sstabletoolchain.CLAUDE.mdtech-stack line to reflect the new pin.Test plan
./deploy-fly.shcompletes the Depot build and the app starts on Flycurl https://mostro-push-server.fly.dev/api/healthreturns OKcurl https://mostro-push-server.fly.dev/api/inforeturns the expected payload