Skip to content

fix(docker): bump builder to rust:1.90 to satisfy dep MSRV#31

Merged
AndreaDiazCorreia merged 1 commit into
mainfrom
fix/docker-builder-rust-1.85
May 15, 2026
Merged

fix(docker): bump builder to rust:1.90 to satisfy dep MSRV#31
AndreaDiazCorreia merged 1 commit into
mainfrom
fix/docker-builder-rust-1.85

Conversation

@AndreaDiazCorreia
Copy link
Copy Markdown
Member

@AndreaDiazCorreia AndreaDiazCorreia commented May 15, 2026

Summary

  • Docker builder was pinned to rust:1.83, but recent transitive deps require newer rustc: getrandom 0.4.2 needs edition2024 (Cargo 1.85+) and time 0.3.47 requires rustc 1.88+. Production deploys were failing on cargo build --release inside the image.
  • Bumps the builder to rust:1.90, which clears both MSRV bumps with margin and stays below CI's stable toolchain.
  • Updates CLAUDE.md tech-stack line to reflect the new pin.

Test plan

  • ./deploy-fly.sh completes the Depot build and the app starts on Fly
  • curl https://mostro-push-server.fly.dev/api/health returns OK
  • curl https://mostro-push-server.fly.dev/api/info returns the expected payload

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Warning

Rate limit exceeded

@AndreaDiazCorreia has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 49 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 45af28ea-8fa2-41a2-ac73-047ed5af3296

📥 Commits

Reviewing files that changed from the base of the PR and between efc357d and 7dfbbe0.

📒 Files selected for processing (2)
  • CLAUDE.md
  • Dockerfile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docker-builder-rust-1.85

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AndreaDiazCorreia AndreaDiazCorreia merged commit e707cde into main May 15, 2026
4 checks passed
@AndreaDiazCorreia AndreaDiazCorreia deleted the fix/docker-builder-rust-1.85 branch May 15, 2026 03:30
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7dfbbe01ae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Dockerfile
@@ -1,4 +1,4 @@
FROM rust:1.83 as builder
FROM rust:1.90 as builder
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep builder and runtime on same Debian release

On the Fly deploy path I checked (fly.toml builds this Dockerfile), rust:1.90 now resolves to the Trixie-based Rust image while the final stage remains debian:bookworm-slim. Because the release binary is dynamically linked against the builder's libc/OpenSSL stack and then copied into an older Bookworm runtime, deploys can build successfully but fail at container start with missing/newer symbol versions. Pin the builder to the matching suite, e.g. rust:1.90-bookworm, or move the runtime stage to Trixie as well.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant