provide an explicit 'match all' index value to SurfaceId

[brownd1978]

Provide an explicit 'match all' value to avoid the implicit 'magic number' value for matching all indices.

[FNALbuild]

Hi @brownd1978,
You have proposed changes to files in these packages:

• KinKalGeom
• DataProducts
• Validation

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 7320f72: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

[FNALbuild]

☀️ The build tests passed at 7320f72.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged 7320f72 at ab8dbf1
build (prof)	✅	Log file. Build time: 08 min 48 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	➡️	TODO (1) FIXME (0) in 3 files
clang-tidy	➡️	2 errors 134 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 7320f72 after being merged into the base branch at ab8dbf1.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[RobMina]

There are a few other call sites in KKFit.hh, CentralHelixFit_module.cc, and KinematicLineFit_module.cc that should be updated -1 -> allIndices_.

There is a stale comment in SurfaceId.hh "Negative value is a wild card" that should be updated.

The same pattern is also used in EventNtuple (and possibly other repos), which should be updated after this PR lands.

[brownd1978]

Thanks for your comments Rob, I updated the PR.

[RobMina]

On second thought, I think changing this to static constexpr int allIndices_ = -1 in the header file makes more sense. That matches how nSurfaceIds is declared earlier in the file. Then you can delete the int SurfaceId::allIndices_(-1) line from the .cc file.