Skip to content

Improvements for reflection tracking and energy loss#1900

Open
brownd1978 wants to merge 10 commits into
Mu2e:mainfrom
brownd1978:refreco
Open

Improvements for reflection tracking and energy loss#1900
brownd1978 wants to merge 10 commits into
Mu2e:mainfrom
brownd1978:refreco

Conversation

@brownd1978

Copy link
Copy Markdown
Collaborator

Improve and simplify extrapolation through reflection, including:

  • fix a bug in reflection tracking between the ST and the IPA
  • improve the test of reflection condition off-axis, where the BField is no longer parallel with Z, when extrapolating to a Z value
  • fix the time interval for extrapolation testing to be a half-open interval (], not a full open (), to fully cover.
    The empirical brehmsstrahlung tail cutoff parameter is retuned to center the reconstructed track momentum at the tracker front, which shifted after the fix to the pathlength bug. The cutoff is now at 30%, down from 40%.

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @brownd1978,
You have proposed changes to files in these packages:

  • Mu2eKinKal
  • TrkReco
  • KinKalGeom
  • DataProducts
  • Validation

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 54b130c: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 54b130c.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 54b130c at 0294ed5
build (prof) Log file. Build time: 04 min 19 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file. Return Code 1.
check_cmake Log file.
FIXME, TODO ➡️ TODO (4) FIXME (0) in 8 files
clang-tidy ➡️ 4 errors 156 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 54b130c after being merged into the base branch at 0294ed5.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@RobMina RobMina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a solid, coherent update. Just one small comment.

int debug_;
double btol_, intertol_, maxdt_, maxdtstep_, minv_;
bool backToTracker_, extrapolateOPA_, toTrackerEnds_, upstream_, toCRV_;
bool backToTracker_, extrapolateOPA_, toTrackerEnds_, upstream_, toCRV_, stopAtTSDA_;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stopAtTSDA_ is declared, but as far as I can tell is not initialized or read anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants