Sc/artdaq system variables#29
Open
corrodis wants to merge 8 commits into
Open
Conversation
The lumi-stream filtering moved out of otsdaq-mu2e-trigger (module now maintained with the Offline/mu2e-trig-config lumi stream work).
Move the table logic into a small library (DBServiceTableImpl.cc) with a
protected name-taking constructor, and add a DBServiceCIDTable plugin
reusing it. Fail configuration early with a clear message when the
TriggerConfigTable menu name/tag resolve empty (e.g. ${OTS.artdaq.*}
system variables not yet set via the Trigger Menu Editor).
|
Thanks! This is to make Cat-2 tables work for trigger, right? |
michaelmackenzie
approved these changes
Jul 20, 2026
michaelmackenzie
left a comment
michaelmackenzie
left a comment
There was a problem hiding this comment.
This looks good to me, thank your for making these updates!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding DBServiceCIDTable in addition to DBServiceTable on request of the Offline/infrastrucutre team.
Tagging @giro94 for awareness. We should switch the calo to also use DBServiceCIDTable and not DBServiceTable.