(Refactor) Email notification, and README file#123
Merged
Conversation
… method, and README
MuhammedMagdyy
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of Pagination and Sorting Utilities:
PaginationServiceclass and its related interfaces (IPagination,IPaginationQuery) and removed their exports. Also removed the unusedISortQuerytype. The corresponding validation schemas were also deleted from and their export removed.DB_COLUMNSconstant to clean up the codebase.Email Notification Improvements:
sendNotifyWinnerEmailtonotifyWinnerViaEmail, both for clarity and consistency.fromfield in the SMTP mail provider to use a more descriptive sender name (Taskora support).Documentation Updates:
README.mdto reflect the addition of Swagger integration, changed "Live Demo" to "Live Preview", updated the active user count to 250, and clarified that the user tracker script now sends email notifications.