-
Notifications
You must be signed in to change notification settings - Fork 1
Assembly lvl2 #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Assembly lvl2 #103
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
1ad96f2
backbone now listed last in product
doublergreer fd65c9a
type correction on ligation products
doublergreer ee7451f
function to simplify complex plasmid part representation to a scar-TU…
doublergreer 5640cd8
intermediate w/ annos not working
doublergreer d4ee967
encapsulate TU annotaitons and sequence
doublergreer e073084
constant list of tuples defining TU fusion site order for l2 assemblies
doublergreer 3c26af0
grab first and last fusion site now in order they appear
doublergreer def5b8b
digestion now takes in Plasmid object; implementation selection happe…
doublergreer 2747758
remove todo
doublergreer 494ddcf
ligase and RE flow optimized + domestication added if not found
doublergreer 69fea09
definition->identity
doublergreer d9fbdf2
lvl2 and multi-design lvl1 drafts
doublergreer 88a3b44
docstring updates
doublergreer 230f2ba
get referencing CD in extract toplevel definition
doublergreer de292b8
ironing out iterative lvl1
doublergreer a0f395c
better doc search in get_or_pull
doublergreer fb76b9c
added combinatorial design support to lvl1
doublergreer 79b6b3a
new tests for digestion and ligation
doublergreer e622941
combinatorial test
doublergreer 4e704fc
type and error handling adjustments
doublergreer a0bb9e0
adjusting backbone arg to allow for dictionary mapping design.display…
doublergreer cc967fe
type correction
doublergreer 4e9f961
activity tests for digestion and ligation
doublergreer 3dc25ee
test buildcompiler draft
doublergreer 7d346cf
level 1 and first comb test complete
doublergreer da38668
removed superfluous prints
doublergreer d2fe409
new test suite
doublergreer feb64fa
synbiohub.org->api.synbiohub.org
doublergreer 3384148
secret access for github job
doublergreer cecf73f
api for pulls only
doublergreer 26e638d
api for collections
doublergreer f91e490
revert api for collections
doublergreer bb8d338
added server mode flag to add api. to canonical sbh registry uris
doublergreer 776bc73
notebooks for creating various implementations used in buildcompiler
doublergreer 767fa6b
decouple forward and reverse fusion site matching to fix skipped back…
doublergreer 0454cfe
lvl2 working
doublergreer 307f61c
lvl2 test draft
doublergreer 9cebf0d
lvl1 TU tests for lvl2 assembly
doublergreer 207b68c
transformation test
doublergreer 1c67d56
notebook updates
doublergreer 2237123
added transformation
doublergreer 28cebdc
Merge branch 'full_build' into assembly_lvl2
Gonza10V 2ed6001
Fix domestication BsaI implementation reference
Gonza10V f10a5b4
Respect supplied level 2 backbone
Gonza10V de4387a
Select top-level design for lvl2 TU extraction
Gonza10V File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
pull_requestruns from forks, GitHub documents that repository secrets are not passed to the runner, so these values expand to empty strings and the newsetUpClasschecks abort the whole unittest suite before any tests run. Because this workflow still runs on everypull_request, external contributors get guaranteed red CI unless the SynBioHub-backed tests are skipped or gated when credentials are absent.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex good catch, please fix this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
unittestsuite only whenSBH_USERNAMEandSBH_PASSWORDare available, preserving the credentialed SynBioHub test path. .github/workflows/python-package.ymlL39-L45pytestwhen secrets are unavailable. .github/workflows/python-package.ymlL46-L50a7c36bcand created a PR titled “Skip SynBioHub tests without credentials.”Testing
git diff --checkbash -n /tmp/python-package-test-step.shpython - <<'PY' from pathlib import Path try: import yaml except ImportError: print('PyYAML not installed; skipping YAML parse') else: with Path('.github/workflows/python-package.yml').open() as f: yaml.safe_load(f) print('YAML parsed successfully') PY(warning due to missing localPyYAML)pytest tests --ignore=tests/test_buildcompiler.py --ignore=tests/test_core.py -q(failed in existing non-online tests withBuildCompilermissing_index_document_objects; unrelated to the workflow-only change)View task →