docs: remove references to files and paths that do not exist#15
Merged
Conversation
A release gate cited a test that is gone. apps/server/CLAUDE.md told readers to keep scripts/build/server/stage.test.ts green as the guard that server production resources never package VM-only Lima files. That test does not exist anywhere in the repository, and native-addon-policy.test.ts — the only other test in that directory — asserts something else entirely. Rather than repoint at a test that would not enforce it, the note now says plainly that the invariant is currently unenforced and must be checked by hand. Two markdown links resolved to nothing: CONTRIBUTING.md pointed at packages/browseros-agent/CONTRIBUTING.md as the authoritative deep dive, and README.md listed an agent-sdk package. Neither exists; the agent workspace keeps its guidance in README.md and CLAUDE.md, and agent-sdk is gone from both the package table and the directory tree. .gitattributes carried seven rules matching nothing, all survivors of the nxtscape rename and a build reorg: four LFS filters under resources/, plus scripts/*.py, build/*, and packages/browseros/build/. Dead LFS filter rules are the dangerous kind — if resources/ is ever recreated those files silently become LFS pointers.
✅ Tests passed — 1446/1450
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while auditing semantic entropy across the estate. Every item verified by
find/ls, not by reading.A release gate points at a test that is gone
packages/browseros-agent/apps/server/CLAUDE.md:58states:find . -name stage.test.ts -not -path '*/node_modules/*'returns nothing. The directory holds onlydescriptor.tsandnative-addon-policy.test.ts, and that test asserts the native-addon policy — bootstrap entrypoint bundling, the addon guard, hidden temp addons — not resource exclusion.So the stated invariant (server builds must not package VM-only Lima resources) is currently unenforced. I did not repoint the reference at
native-addon-policy.test.ts, because that would claim coverage that does not exist. The note now says so explicitly and asks for a manual check. Restoring a real test is worth a follow-up.Two links resolve to nothing
CONTRIBUTING.md:87— "For detailed setup, architecture, and code standards, see…"packages/browseros-agent/CONTRIBUTING.mdREADME.md:173— package table rowpackages/browseros-agent/packages/agent-sdk/The first is the emphasised authoritative deep dive; the agent workspace actually keeps that guidance in
README.mdandCLAUDE.md, which is where it now points. The second is a package that no longer exists —packages/containsbrowser-core,browser-mcp,build-server-tools,cdp-protocol,shared. Removed from the table and from the directory tree at:161.Every other relative link in both files resolves.
.gitattributes— 7 of 13 rules match nothingAll survivors of the
nxtscaperename and a build reorg:resources/— the directory does not existscripts/*.py—scripts/holds one shell scriptbuild/*andpackages/browseros/build/**/*.py— neither directory existsDead
linguist-*rules are only noise, but dead LFS filter rules are the dangerous kind: ifresources/is ever recreated, four files silently become LFS pointers. The three live rules (docs/videos/,chromium_patches,apps/eval) are untouched, along with the orphaned section comment.Scope
Documentation and
.gitattributesonly — no source, test, or workflow behaviour changes.