fix(projects): tighten public project listing filters#1458
Open
vcnainala wants to merge 2 commits into
Open
Conversation
Exclude deleted projects and projects that lack at least one public, non-archived study from the public projects page and text search.
Let the notification component read from page props directly instead of receiving a redundant prop from the layout.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #1458 +/- ##
=================================================
+ Coverage 76.59% 76.62% +0.03%
Complexity 3590 3590
=================================================
Files 249 249
Lines 13510 13530 +20
=================================================
+ Hits 10348 10368 +20
Misses 3162 3162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notificationprop fromAppLayout(component already reads from page props)Commits
fix(projects): only list public projects with visible studiesfix(ui): stop passing stale notifications prop in AppLayoutTest plan
php artisan test tests/Feature/PublicProjectsPageTest.php/projectsand confirm only projects with visible public studies appear