Skip to content

fix(projects): tighten public project listing filters#1458

Open
vcnainala wants to merge 2 commits into
developmentfrom
fix/public-projects-listing
Open

fix(projects): tighten public project listing filters#1458
vcnainala wants to merge 2 commits into
developmentfrom
fix/public-projects-listing

Conversation

@vcnainala

Copy link
Copy Markdown
Member

Summary

  • Exclude deleted projects from the public projects page and public text search
  • Only show public projects that have at least one public, non-archived, non-deleted study
  • Remove redundant notification prop from AppLayout (component already reads from page props)

Commits

  1. fix(projects): only list public projects with visible studies
  2. fix(ui): stop passing stale notifications prop in AppLayout

Test plan

  • php artisan test tests/Feature/PublicProjectsPageTest.php
  • Visit /projects and confirm only projects with visible public studies appear
  • Confirm notifications dropdown still works in the app layout

Exclude deleted projects and projects that lack at least one public,
non-archived study from the public projects page and text search.
Let the notification component read from page props directly instead of
receiving a redundant prop from the layout.
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.62%. Comparing base (f9fb6af) to head (32e3775).

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1458      +/-   ##
=================================================
+ Coverage          76.59%   76.62%   +0.03%     
  Complexity          3590     3590              
=================================================
  Files                249      249              
  Lines              13510    13530      +20     
=================================================
+ Hits               10348    10368      +20     
  Misses              3162     3162              
Flag Coverage Δ
unittests 76.62% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant