fix: remove nodejs.nmrxiv.org references in favor of NMRKit#1460
Open
vcnainala wants to merge 3 commits into
Open
fix: remove nodejs.nmrxiv.org references in favor of NMRKit#1460vcnainala wants to merge 3 commits into
vcnainala wants to merge 3 commits into
Conversation
Update NMRKIT_URL defaults and derive NMRium/NMRKit dns-prefetch hints from configuration instead of hardcoding the retired nodejs host. Refs #1429
Replace the hardcoded legacy spectra-parser endpoint with the NMRKit parse/url API, normalize nmriumState responses, and align tests with the updated request contract. Refs #1429
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1460 +/- ##
=================================================
- Coverage 76.59% 76.57% -0.02%
- Complexity 3590 3594 +4
=================================================
Files 249 249
Lines 13510 13520 +10
=================================================
+ Hits 10348 10353 +5
- Misses 3162 3167 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodejs.nmrxiv.orgreferences withnmrkit.nmrxiv.orgin config, env defaults, and Blade dns-prefetch hintsProcessELNSpectrafrom the legacy hardcoded/spectra-parserendpoint to the configurable NMRKit/latest/spectra/parse/urlAPICloses #1429
Test plan
NMRKIT_URL/NMRKIT_API_URLpoint tohttps://nmrkit.nmrxiv.orgin deployment envphp artisan test tests/Unit/Jobs/ProcessELNSpectraTest.php