fix(ui): render molecular formula numbers as subscripts#1461
Open
vcnainala wants to merge 1 commit into
Open
Conversation
Add a shared MolecularFormula component and use it wherever molecular formulas are shown so counts display in standard chemical notation. Closes #1432
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
============================================
- Coverage 76.59% 76.58% -0.01%
Complexity 3590 3590
============================================
Files 249 249
Lines 13510 13510
============================================
- Hits 10348 10347 -1
- Misses 3162 3163 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MolecularFormulaVue component andparseMolecularFormulaDisplayPartsutility to render molecular formula counts as subscripts (e.g. C9H8O4).MolecularInfoPanel), molecule cards (MoleculeCard), and the public studies header (Public/Studies).Closes #1432
Test plan
CH<sub>2</sub>O) still render correctly after tag stripping