feat(public): display MIChI spectrum metadata on dataset page#1470
Open
vcnainala wants to merge 1 commit into
Open
feat(public): display MIChI spectrum metadata on dataset page#1470vcnainala wants to merge 1 commit into
vcnainala wants to merge 1 commit into
Conversation
Extract MIChI v1 fields with NMRium mapping from spectrum info and processing filters, and merge them into the public dataset spectrum info table ahead of remaining raw NMRium keys. Closes #993
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #1470 +/- ##
==============================================
Coverage 76.59% 76.59%
Complexity 3593 3593
==============================================
Files 250 250
Lines 13521 13521
==============================================
Hits 10357 10357
Misses 3164 3164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
michiSpectrumInfo.jsto extract MIChI v1 fields that have an NMRium mapping (fromspectra[0].infoandspectra[0].filters)michiStandardsUrlInertia propImplements the display scope of #993 (no DB columns, import command, or search filters in this PR).
Test plan
filtersstill render info-only MIChI fields