Skip to content

Chore: [AEA-0000] - remove git secrets #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anthony-nhs wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Chore: [AEA-0000] - remove git secrets #103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
960ea60
remove git secrets
anthony-nhs Apr 21, 2026
0ec1f0a
remove more gitsecret stuff
anthony-nhs Apr 22, 2026
5fddb02
more tidy
anthony-nhs Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/base/.devcontainer/Mk/check.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,7 @@ actionlint:
actionlint

secret-scan:
@if [ -f .gitallowed ]; then \
git-secrets --scan-history .; \
else \
gitleaks -v --redact git; \
fi
gitleaks -v --redact git
Comment thread
anthony-nhs marked this conversation as resolved.

guard-%:
@ if [ "${${*}}" = "" ]; then \
Expand Down
11 changes: 0 additions & 11 deletions src/base/.devcontainer/scripts/root_install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,6 @@ VERSION="${DIRENV_VERSION}" "${SCRIPTS_DIR}/${CONTAINER_NAME}/install_direnv.sh"
# install yq
VERSION="${YQ_VERSION}" "${SCRIPTS_DIR}/${CONTAINER_NAME}/install_yq.sh"

# install gitsecrets
# this should be removed once we have migrated all repos to gitleaks
git clone https://github.com/awslabs/git-secrets.git /tmp/git-secrets
cd /tmp/git-secrets
make install
cd
rm -rf /tmp/git-secrets
mkdir -p /usr/share/secrets-scanner
chmod 755 /usr/share/secrets-scanner
curl -L https://raw.githubusercontent.com/NHSDigital/software-engineering-quality-framework/main/tools/nhsd-git-secrets/nhsd-rules-deny.txt -o /usr/share/secrets-scanner/nhsd-rules-deny.txt

# get cfn-guard ruleset
tmp_dir="$(mktemp -d)"
Comment thread
anthony-nhs marked this conversation as resolved.
trap 'rm -rf "${tmp_dir}"' EXIT
Expand Down