Skip to content

Adding new options and actions. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NSTechBytes merged 17 commits into from
Dec 12, 2025
Merged

Adding new options and actions. #7

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9388022
Add new member variables for action handling
RicardoTM05 Dec 8, 2025
aa35a93
Add OnFinishAction and OnPageLoadAction handling
RicardoTM05 Dec 8, 2025
67d7812
Prevent multiple creation of WebView2 environment
RicardoTM05 Dec 8, 2025
c3643f7
Refactor WebView2 creation logic for better validation
RicardoTM05 Dec 8, 2025
8e1c7f2
Remove unnecessary Rainmeter redraw triggers
RicardoTM05 Dec 8, 2025
e0111e1
Implement synchronous script execution in WebView2
RicardoTM05 Dec 9, 2025
3899200
Restore to previous working version.
RicardoTM05 Dec 9, 2025
fcfc077
Add new properties and UpdateRaincontext function
RicardoTM05 Dec 10, 2025
b48bf00
Add raincontext management to Measure class
RicardoTM05 Dec 10, 2025
edb5084
Added handling of new actions and raincontext.
RicardoTM05 Dec 10, 2025
8e397a9
Refactor for dual control handling
RicardoTM05 Dec 11, 2025
90c430d
Implement AllowDualControl feature
RicardoTM05 Dec 11, 2025
38144bc
Add currentUrl member to Plugin class
RicardoTM05 Dec 11, 2025
899ddf8
Update WebView2.cpp
RicardoTM05 Dec 11, 2025
24ce69e
added zoomFactor double
RicardoTM05 Dec 11, 2025
3de406e
added zoomFactor
RicardoTM05 Dec 11, 2025
2834a3a
Added ZoomFactor
RicardoTM05 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions WebView2/Plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,13 +300,6 @@ PLUGIN_EXPORT double Update(void* data)
{
measure->callbackResult = result;
}

// Trigger Rainmeter redraw after callback completes
if (measure->skin)
{
RmExecute(measure->skin, L"!UpdateMeter *");
RmExecute(measure->skin, L"!Redraw");
}
Copy link
Copy Markdown
Contributor Author

@RicardoTM05 RicardoTM05 Dec 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, we need to avoid these unnecessary global updates.
This was causing CallJS to execute twice when called. See JSInteraction.ini, it's being logged twice. Removing this fixed it.

Note: The 1 update delay on the result on that demo skin may be unavoidable. Other ways to fix that may be investigated anyway. However, I find it unlikely due to the calls being async, so we may have to live with it (not a big deal anyways).

We could try doing it synchronously instead, unfortunately WebView2 doesn't offer a synchronous ExecuteScript function, however, someone offered a solution that we could try. Yep, we would risk blocking rainmeter for heavy scripts, but I think lua does block rainmeter too when scripts are heavy, so it may not be such a big deal. We would do it synchronously only for ExecuteScript calls by the way.

Here’s another, pretty long conversation about the same topic.

}
return S_OK;
}
Expand Down