fix(evaluator): preserve non-string stream values#824
Draft
ngoncharenko wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concatinstead of coercing it withstr()concatstreams as partial results with an actionable errorRoot cause
PR #812 changed NAT stream aggregation to
concat. Its accumulator converted every matched non-string value to a Python string representation.For example:
A single structured result is not a token delta, so this patch preserves its original JSON type. Text deltas such as
["15", ".", "0"]still become"15.0".Validation
uv run --frozen pytest packages/nemo_evaluator_sdk/tests -q: 1125 passed, 2 skippeduv run --frozen pre-commit run: passedtools/lint/lint-sdk-vendored.sh: passedgit diff --check origin/main...HEAD: passed