Fix _from_pretrained signature for huggingface_hub>=0.23 compatibility#11
Open
nickpierce24 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fix _from_pretrained signature for huggingface_hub>=0.23 compatibility#11nickpierce24 wants to merge 1 commit intoNVIDIA:mainfrom
nickpierce24 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigVGAN’s requirements.txt specifies huggingface_hub>=0.23.4, but the _from_pretrained method in bigvgan.py still uses the older signature from pre‑0.20 versions of the HuggingFace Hub API.
This causes the following error when calling BigVGAN.from_pretrained():
TypeError: BigVGAN._from_pretrained() missing 2 required keyword-only arguments: 'proxies' and 'resume_download'
This PR updates the method signature to match the current ModelHubMixin API. The fix is minimal and restores compatibility with the required HF Hub version.
Testing