[gareth-morgan-nv]

Summary

Real-browser integration tests for the OOB teleop path. The merged fake-adb test double plays the headset's adb, real Chrome opens the exact URL that am start receives, the real web client (MockCloudXR build) runs in it, and the real wss.run + OOBControlHub serve it. Based on the fragment-token PR (#1318); retarget to main once that merges.

What changed

One real-browser suite, tests/python/core/cloudxr/test_oob_browser_integration.py, sharing one build, browser, hub and adb cleanup:

• A fast /bin/sh test (always runs) that the -d URL survives shell quoting with a token containing &, ?, #, +, a space and quotes.
• Fragment token delivery (generated and awkward configured token): the token is only in the launch URL's fragment after the route, the hub accepts the client, the page URL is cleaned, the mock session reports streaming, and no request target or Referer seen by the static server contains the token.
• A wrong fragment token is rejected: the client logs the 1008 policy close and the hub has no headset.
• A stream-attach timeout set in the environment travels in the bookmark and fires in the page.
• A terminal client error from the mock session (server-disconnect range) shows the DOM error banner.

The browser cases need Chrome and an npm build, so they run only with RUN_OOB_BROWSER_TESTS=1 (-m oob_browser); a default run skips them. Chrome there ignores TLS errors, so certificate trust is bypassed, not covered. The older real-browser helpers in conftest.py and their two tests are removed; conftest.py keeps the shared fake-adb and service mocks. Adds the cryptography test dependency and the oob_browser marker in the leaf pyproject.toml.

Validation

• RUN_OOB_BROWSER_TESTS=1 uv run --extra dev pytest test_oob_browser_integration.py in tests/python/core/cloudxr: 6 passed. The default run of that directory's adb tests (browser cases skipped): 124 passed, 5 skipped.
• Hand mutation checks on the token cases (each made the tests fail): no token capture in the client, no sessionStorage persistence, token also in the URL query, hub accepting any token, URL not shell-quoted.
• SKIP=check-copyright-year pre-commit run --all-files clean.
• The attach-timeout and error-banner cases have no mutation check yet.
• The new browser cases are not run by CI.

Known limitations / follow-ups

• This suite does not exercise reload persistence; the jest and Playwright tests from the fragment-token PR cover it. A reload step in the browser suite was flaky and is not included.
• There is no relaunch-after-crash case: the reliability work it would test has not landed.
• The hub API's cross-origin refusal is not tested here: a draft test did not fail when that behaviour was reverted, so it was not shown to catch a regression.

Test plan

• CI checks pass on this PR.

PR description drafted with Claude Code (Claude Sonnet 5.5).

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: NVIDIA/IsaacCapture
• Branch: gmorgan/oob-hub-token-fragment
• File: .coderabbit.yaml
• Commit: 9d3b091
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 201ee385-a830-40f5-8d98-66599c7e3e88

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

✅ Preview deployed: https://NVIDIA.github.io/IsaacCapture/preview/pr-1148/client/

Built from commit 319f41e. It may take a minute for the updated preview to appear.