Add LSQ NVFP4 export support#1847
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
realAsma
left a comment
There was a problem hiding this comment.
BB: Rebase this PR to the latest main, remove the unnecessary changes.
🐝 I’m on it — I’ll rebase onto the latest |
Blocked before rebase: this PR still targets |
|
BB: Can you rebase this PR to latest main and only add the changes required to enable export with LSQ? (btw, I have renamed LAQ to LSQ, see #1884) |
|
BB: Please update PR description and PR title after addressing #1847 (comment) |
🐝 I’m on it — I’ll rebase onto the latest |
🐝 Acknowledged this instruction. I’ll update the PR title and description after addressing the linked feedback. |
🐝 Got it — I’ll update the PR title and description to match the narrowed LSQ-export scope after the branch changes are prepared. |
Blocked for now: the PR still declares |
Blocked outcome for the title/description request: the guarded pass paused because the PR still targets |
|
BB: Yes please retarget this PR to latest main. then address #1847 (comment) |
🐝 Acknowledged — I’ll retarget this PR to the latest |
Blocked after the requested retarget attempt: I safely cleared the unpublished wrong-base rebase and restored |
|
BB: Done, I manually rebase to main. do the rest. |
Update: the live PR base is now |
🐝 Got it — I’m taking over from the manual rebase and will finish the LSQ export work, validation, and PR metadata updates. |
I verified the PR now targets |
Signed-off-by: realAsma <akuriparambi@nvidia.com>
30e8b91 to
448e58e
Compare
🐝 Updated this PR to the requested LSQ-export-only scope.
The PR remains draft; no ready-for-review promotion or reviewer notification was made. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1847 +/- ##
==========================================
+ Coverage 75.84% 75.86% +0.01%
==========================================
Files 518 518
Lines 58544 58586 +42
==========================================
+ Hits 44404 44445 +41
- Misses 14140 14141 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Adds LSQ NVFP4 support to unified Hugging Face export.
Testing
pre-commit run --files modelopt/torch/export/quant_utils.py modelopt/torch/export/unified_export_hf.py tests/unit/torch/quantization/test_nvfp4_static_export_cpu.pypytest_pwd tests/unit/torch/quantization/test_lsq.py tests/unit/torch/quantization/test_nvfp4_static_export_cpu.py -q -x— 66 passedpytest_pwd tests/unit/torch/quantization/test_nvfp4_static_export_cpu.py -q -x— 18 passedChecklist