Skip to content

Link puzzletronv2 in CHANGELOG.rst#2007

Merged
Separius merged 1 commit into
mainfrom
Separius-patch-2
Jul 22, 2026
Merged

Link puzzletronv2 in CHANGELOG.rst#2007
Separius merged 1 commit into
mainfrom
Separius-patch-2

Conversation

@Separius

@Separius Separius commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Added a changelog entry describing experimental example pruning for Qwen3.5-9B and Nemotron3-Nano.
    • Documented the new experimental puzzletron branch and its improved parallelization and efficiency.

Signed-off-by: Sepehr Sameni <ssameni@nvidia.com>
@Separius
Separius requested a review from a team as a code owner July 22, 2026 07:25
@Separius
Separius requested a review from kevalmorabia97 July 22, 2026 07:25
@Separius
Separius enabled auto-merge (squash) July 22, 2026 07:25
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The changelog’s Experimental section adds pruning example coverage for Qwen3.5-9B and Nemotron3-Nano, references the experimental puzzletron branch, and notes its use of AutoModel for parallelization and efficiency.

Changes

Experimental pruning documentation

Layer / File(s) Summary
Pruning example changelog entry
CHANGELOG.rst
Adds an Experimental entry covering Qwen3.5-9B and Nemotron3-Nano pruning examples and documenting the puzzletron branch’s AutoModel usage.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: kevalmorabia97, edwardf0t1, realasma, gcunhase, ajrasane

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and points to the changelog update about puzzletron, which matches the change set.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed PR only changes CHANGELOG.rst; no modelopt/examples Python or dependency files were modified, so none of the listed security anti-patterns are present.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Separius-patch-2

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.

Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.

👉 Steps to fix this

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.rst`:
- Line 7: Update the pruning examples changelog entry to link the AutoModel
reference to the Puzzletron-compatible Separius/Automodel fork on its puzzletron
branch, replacing the current NVIDIA-NeMo/Automodel link while preserving the
surrounding text and Puzzletron README link.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3c45c1ff-0e82-4534-98e7-0fe5cc0127e1

📥 Commits

Reviewing files that changed from the base of the PR and between 8813b70 and 2ee434a.

📒 Files selected for processing (1)
  • CHANGELOG.rst

Comment thread CHANGELOG.rst
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.76%. Comparing base (8813b70) to head (2ee434a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2007   +/-   ##
=======================================
  Coverage   75.76%   75.76%           
=======================================
  Files         518      518           
  Lines       58269    58269           
=======================================
  Hits        44148    44148           
  Misses      14121    14121           
Flag Coverage Δ
unit 54.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chochowski chochowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Separius
Separius merged commit 14a180d into main Jul 22, 2026
37 checks passed
@Separius
Separius deleted the Separius-patch-2 branch July 22, 2026 13:20
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-22 13:20 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants