Forward-merge release/0.3 into main#191
Merged
Merged
Conversation
#### Overview Register the adaptive plugin component before `nemo-relay doctor` validates plugin configuration, and make Cursor support limitations more explicit in the CLI docs. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Register the built-in adaptive component before doctor plugin validation so adaptive plugin configs no longer report `plugin.unknown_component`. - Add a focused doctor regression test for adaptive validation. - Mark Cursor support as partial/highly experimental in the CLI overview. - Add prominent Cursor cautions for Fern and GitHub docs covering manual proxy/API-key setup, lack of automatic model routing, and subagent model behavior. Validation: - `cargo fmt --check` - `cargo test -p nemo-relay-cli collect_observability_registers_adaptive_before_validation -- --nocapture` - `just docs` - Commit pre-checks: docs linkcheck, `cargo fmt`, `cargo clippy`, and `cargo check` #### Where should the reviewer start? Start with `crates/cli/src/doctor.rs` for the adaptive registration path, then `docs/nemo-relay-cli/cursor.mdx` for the Cursor support warning. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: none ## Summary by CodeRabbit * **Documentation** * Clarified Cursor integration support as highly experimental with limitations; cannot automatically route model traffic through the gateway * Updated observability support matrix for Cursor from fully supported to partial (highly experimental) * **New Features** * Enhanced doctor command to register adaptive components during observability health checks [](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Relay/pull/186?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) Authors: - Will Killian (https://github.com/willkill07) Approvers: - Bryan Bednarski (https://github.com/bbednarski9) URL: #186
Author
|
SUCCESS - forward-merge complete. |
](https://app.coderabbit.ai/change-stack/NVIDIA/NeMo-Relay/pull/186?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack){kind=link}
github-actions
Bot
added
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.3 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.