fix(debug): explain restricted dmesg output#3890
Conversation
Signed-off-by: John Liu <lijohn@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds permission-aware gating for kernel message diagnostics. Detects when non-root users lack dmesg access via ChangesDmesg Permission-Aware Collection
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
Summary
Improve
nemoclaw debug --quickso restricteddmesgoutput is reported as an intentional skipped diagnostic instead of a rawOperation not permittederror. This makes debug reports clearer for non-root Linux users whenkernel.dmesg_restrict=1blocks kernel ring buffer access.Related Issue
Fixes #3738
Changes
dmesgfailures in the debug diagnostics path.dmesg: read kernel buffer failed: Operation not permittedoutput with an actionable skipped message that explainskernel.dmesg_restrict=1.dmesgbehavior while preserving normal debug output behavior.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Additional checks run:
npm run build:clinpx vitest run src/lib/diagnostics/debug.test.tsgit diff --check upstream/main...HEADNotes:
7 failed | 310 passed | 1 skipped,114 failed | 3760 passed | 8 skipped). The targeted debug test and CLI build both pass on this branch.Signed-off-by: John Liu lijohn@nvidia.com
Summary by CodeRabbit
Bug Fixes
Tests