fix(cli): clarify live gateway drift in list#3907
Conversation
Signed-off-by: Chengjie Wang <chengjiew@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR updates inventory drift messaging to clarify when live OpenShell gateway values differ from onboarded configuration. Documentation, implementation, and test assertions are updated consistently to reflect the new explicit message format across the CLI output, unit tests, and integration tests. ChangesDrift message clarification for live gateway vs onboarded state
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
PR Review AdvisorRecommendation: info only This is an automated advisory review. A human maintainer must make the final merge decision. Limitations: Advisor execution failed: Could not configure advisor model openai/openai/gpt-5.5 Full advisor summaryPR Review AdvisorBase: PR review advisor failed: Could not configure advisor model openai/openai/gpt-5.5 Gate status
🔴 Blockers
🟡 Warnings
🔵 Suggestions
Acceptance coverage
Security review
Test / E2E status
✅ What looks good
Review completeness
|
E2E Advisor RecommendationRequired E2E: None Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Summary
Clarifies the
nemoclaw listdrift annotation so users can tell the row is using live OpenShell gateway inference state, not only the onboarded snapshot. This addresses the confusion in #3822 where killing a sandbox container leaves the gateway reachable and the drift line still valid.Related Issue
Fixes #3822
Changes
(onboarded: ...)to(live OpenShell gateway differs from onboarded: ...).Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Focused commands run:
git diff --checknpx vitest run --project cli src/lib/inventory/index.test.tsnpx vitest run --project cli test/cli.test.ts -t "list shows live gateway inference"npm run typecheck:cliNote: I did not mark
npx prek run --all-filesbecause the repo pre-commit hook recursively invoked itself when the full CLI coverage suite ran a nested git-commit test with the parent hook Git environment. The focused tests and typecheck above passed.Signed-off-by: Chengjie Wang chengjiew@nvidia.com
Summary by CodeRabbit