Revert "fix(snapshot): use gateway metadata for VM-driver health checks (#3784)"#3929
Closed
jyaunches wants to merge 1 commit into
Closed
Revert "fix(snapshot): use gateway metadata for VM-driver health checks (#3784)"#3929jyaunches wants to merge 1 commit into
jyaunches wants to merge 1 commit into
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR updates sandbox snapshot gateway detection for Docker-based sandboxes. The code replaces metadata-based health checks with a Docker-specific probe that parses ChangesDocker gateway probe and test updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Auto-dispatched E2E: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Contributor
PR Review AdvisorRecommendation: blocked This is an automated advisory review. A human maintainer must make the final merge decision. Limitations: Review used trusted PR metadata, status context data, linked issue/comment text, and the provided diff; no PR scripts, tests, package-manager commands, or workflows were executed.; Current CI and E2E jobs were still pending at the time of review.; No E2E Advisor recommendation comment was available in the provided context.; CodeRabbit review for the current PR was still pending, so final automated review findings may not yet be reflected.; The current PR is a revert; human maintainers should confirm the reason for reverting #3784 and whether reopening the #3567 behavior is intended. Full advisor summaryPR Review AdvisorBase: This revert is currently blocked by pending CI/mergeability and appears to reintroduce the known macOS VM-driver snapshot failure by removing the VM gateway metadata probe and its regression test. Gate status
🔴 Blockers
🟡 Warnings
🔵 Suggestions
Acceptance coverage
Security review
Test / E2E status
✅ What looks good
Review completeness
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/snapshot-gateway-guard.test.ts (1)
65-67: ⚡ Quick winExercise the docker-driver gateway probe path in this fixture.
Line 65-Line 67 currently omits
openshellDriver: "docker", so this setup can validate the fallback inspect path instead of the new docker-specific probe branch insnapshot.ts.Suggested fixture update
sandboxes: { alpha: { name: "alpha", + openshellDriver: "docker", model: "test-model", provider: "nvidia-prod", gpuEnabled: false, policies: [], }, @@ [ "#!/bin/sh", + 'if [ "$1" = "status" ]; then', + ' printf "Status: Disconnected\\n"', + " exit 0", + "fi", 'if [ "$1" = "sandbox" ] && [ "$2" = "list" ]; then', ' printf "NAME STATUS\\nalpha Ready\\n"', " exit 0", "fi", "exit 0",Also applies to: 83-89
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/snapshot-gateway-guard.test.ts` around lines 65 - 67, Update the test fixture objects used by the snapshot gateway guard so they exercise the docker-specific probe branch: add openshellDriver: "docker" to the "alpha" fixture object (the one with name: "alpha", model: "test-model") referenced in this test and likewise add openshellDriver: "docker" to the other fixture block around lines 83-89; this ensures snapshot.ts's docker-driver gateway probe path is executed instead of the fallback inspect path when running the test.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/snapshot-gateway-guard.test.ts`:
- Around line 65-67: Update the test fixture objects used by the snapshot
gateway guard so they exercise the docker-specific probe branch: add
openshellDriver: "docker" to the "alpha" fixture object (the one with name:
"alpha", model: "test-model") referenced in this test and likewise add
openshellDriver: "docker" to the other fixture block around lines 83-89; this
ensures snapshot.ts's docker-driver gateway probe path is executed instead of
the fallback inspect path when running the test.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b086b367-db9a-48df-a636-8b829f9a1228
📒 Files selected for processing (2)
src/lib/actions/sandbox/snapshot.tstest/snapshot-gateway-guard.test.ts
Contributor
Selective E2E Results — ❌ Some jobs failedRun: 26189690588
|
cv
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(snapshot): use gateway metadata for VM-driver health checks)Verification
git revert --signoff --no-edit 36491d2fdab5f575c0e4b1a799346247a6742242git diff --check HEAD^ HEADSummary by CodeRabbit
Bug Fixes
Tests