fix(onboard): use generic inference step label

[glenn-agent]

Summary

Fixes the onboarding step 3 banner so provider selection is labeled generically as Configuring inference instead of always implying a NIM backend is being configured.

Related Issue

Fixes #3951

Changes

• Remove the hard-coded (NIM) qualifier from the live provider-selection step banner.
• Keep resume/reuse provider-selection banners consistent with the generic label.
• Add a provider-selection UX assertion that the non-NIM default path no longer prints Configuring inference (NIM).

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

Additional checks run:

• npm run build:cli
• npm test -- --run test/onboard-selection.test.ts
• npm run typecheck:cli
• git diff --check

---

Signed-off-by: Glenn-Agent glenn_agent@163.com

Summary by CodeRabbit

• Bug Fixes

  • Updated the onboarding step title displayed when configuring the inference provider to remove an erroneous label suffix, ensuring the correct title appears in the wizard UI.

• Tests

  • Enhanced test assertions to verify the updated onboarding step title displays correctly and legacy labels are no longer shown.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 41723811-10e7-4fca-b36d-488d765f3230

📥 Commits

Reviewing files that changed from the base of the PR and between 18c7265 and 29899e9.

📒 Files selected for processing (2)

• src/lib/onboard.ts
• test/onboard-selection.test.ts

---

📝 Walkthrough

Walkthrough

The onboarding step [3/8] banner is renamed from "Configuring inference (NIM)" to "Configuring inference" in two locations within the step metadata and output, making the label provider-agnostic. Test assertions are added to verify the generic label appears and the NIM-specific variant is absent.

Inference step label normalization

Layer / File(s)	Summary
Generic inference provider step label src/lib/onboard.ts, test/onboard-selection.test.ts	Step [3/8] title changed from "Configuring inference (NIM)" to "Configuring inference" in setupNim console output and ONBOARD_STEP_INDEX metadata. Test assertions added to confirm the generic label [3/8] Configuring inference is present and Configuring inference (NIM) is absent from the wizard transcript.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

v0.0.44

Suggested reviewers

• cv

Poem

A label so simple, yet causing a stir—
"NIM" in the banner when other paths blur. 🐰
Now inference shines with no brand on its brow,
Each provider their own, take a bow. 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(onboard): use generic inference step label' directly and clearly summarizes the main change: removing the hard-coded '(NIM)' qualifier from the onboarding step 3 banner to make it provider-agnostic.
Linked Issues check	✅ Passed	The PR successfully addresses the requirements from issue #3951 by changing the step label from 'Configuring inference (NIM)' to the generic 'Configuring inference' in both live and resume paths, and adding test assertions to verify the non-NIM path behavior.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the issue: updating the onboarding step label in src/lib/onboard.ts and adding corresponding test assertions in test/onboard-selection.test.ts, with no unrelated modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}