Skip to content

docs(test): remove historical performance snapshot#6422

Merged
cv merged 1 commit into
mainfrom
codex/remove-test-performance-history
Jul 7, 2026
Merged

docs(test): remove historical performance snapshot#6422
cv merged 1 commit into
mainfrom
codex/remove-test-performance-history

Conversation

@cv

@cv cv commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

Remove the dated #6245 performance snapshot now that the issue is closed. This keeps repository documentation focused on current behavior while retaining historical measurements in Git history, the issue, and PR #6420.

Related Issue

Follow-up cleanup after #6245.

Changes

  • Delete test/README.md, which contained host-specific timings, historical hotspot classifications, and the completed optimization narrative.
  • Preserve active #6245 regression-test suffixes and current Vitest scheduling comments because they still document behavior rather than historical run data.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification: This deletes an unreferenced archival Markdown snapshot and does not change code, test selection, or runtime behavior.
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: No user-facing docs/ content changes; this removes an internal historical test artifact.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

  • PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: Repository scans found no remaining perf(test): reduce test I/O to restore 2–5 minute full-suite runs #6245 Markdown/MDX or recorded timing strings; npm run test:projects:check reports 1,328 files disjoint across 8 projects.
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only) — command passed; Fern reported two advisory warnings, so this remains intentionally unchecked.
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

  • Documentation
    • Removed the test suite README and its related performance notes, measurement details, results tables, and coverage breakdowns.

@cv cv self-assigned this Jul 7, 2026
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e3402a14-b794-46d6-bffa-6a84e7067e40

📥 Commits

Reviewing files that changed from the base of the PR and between 8ba3d0b and 87c4a92.

📒 Files selected for processing (1)
  • test/README.md
💤 Files with no reviewable changes (1)
  • test/README.md

📝 Walkthrough

Walkthrough

The test/README.md file was deleted, removing documentation of the NemoClaw test suite's performance reference, measurement methodology, results tables, and coverage breakdowns. No code or exported entities were changed.

Changes

Cohort / File(s) Summary
Documentation Removal
test/README.md
Deleted file containing test suite documentation, including performance benchmarks, measurement methods, and coverage details.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing a historical performance snapshot from test documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/remove-test-performance-history

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • None. No E2E is recommended because this is a documentation-only change deleting test-suite README content; it cannot affect NemoClaw runtime behavior or live user flows.

Optional E2E

  • None.

New E2E recommendations

  • None.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

E2E Target Recommendation

Required E2E targets: None
Optional E2E targets: None

Workflow run

Full E2E target advisor summary

E2E Target Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E targets

  • None. Only a test-suite README/documentation file outside test/e2e changed; this cannot affect E2E target behavior or dispatch wiring.

Optional E2E targets

  • None.

Relevant changed files

  • None.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: No advisor follow-up required beyond maintainer review.
Open items: 0 required · 0 warnings · 0 suggestions · 0 test follow-ups
Since last review: 0 prior items resolved · 0 still apply · 0 new items found

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor (Nemotron Ultra) — No blocking findings

Merge posture: No blocking advisor findings
Primary next action: No advisor follow-up required beyond maintainer review.
Open items: 0 required · 0 warnings · 0 suggestions · 0 test follow-ups
Since last review: 0 prior items resolved · 0 still apply · 0 new items found

Workflow run details

This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision.

@cv
cv merged commit c5a504e into main Jul 7, 2026
44 checks passed
@cv
cv deleted the codex/remove-test-performance-history branch July 7, 2026 23:20
@github-actions github-actions Bot added the v0.0.76 Release target label Jul 7, 2026
Hadar301 pushed a commit to Hadar301/NemoClaw-OpenShift that referenced this pull request Jul 12, 2026
<!-- markdownlint-disable MD041 -->
## Summary
Remove the dated NVIDIA#6245 performance snapshot now that the issue is
closed. This keeps repository documentation focused on current behavior
while retaining historical measurements in Git history, the issue, and
PR NVIDIA#6420.

## Related Issue
Follow-up cleanup after NVIDIA#6245.

## Changes
- Delete `test/README.md`, which contained host-specific timings,
historical hotspot classifications, and the completed optimization
narrative.
- Preserve active `NVIDIA#6245` regression-test suffixes and current Vitest
scheduling comments because they still document behavior rather than
historical run data.

## Type of Change

- [ ] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [x] Doc only (prose changes, no code sample modifications)
- [ ] Doc only (includes code sample changes)

## Quality Gates
<!-- Check exactly one tests line and one docs line. Check other lines
when applicable. Add every requested justification or approval
reference. -->
- [ ] Tests added or updated for changed behavior
- [ ] Existing tests cover changed behavior — justification:
- [x] Tests not applicable — justification: This deletes an unreferenced
archival Markdown snapshot and does not change code, test selection, or
runtime behavior.
- [ ] Docs updated for user-facing behavior changes
- [x] Docs not applicable — justification: No user-facing `docs/`
content changes; this removes an internal historical test artifact.
- [ ] Sensitive paths changed (security, policy, credentials, preflight,
onboarding, inference, runner, sandbox, or messaging)
- [ ] Sensitive-path review completed or maintainer-approved waiver
recorded — reviewer/approval link/justification:
- [ ] Non-success, skipped, or missing CI check accepted by maintainer —
check name, approval link, and follow-up issue:

## Verification
<!-- Check each applicable item only when supported by the requested
evidence. Run targeted tests once per relevant change set and rerun
after later edits or hook autofixes that can affect that behavior. Do
not rerun hook-covered checks. -->
- [x] PR description includes the DCO sign-off declaration and every
commit appears as `Verified` in GitHub
- [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or
`npm run check:diff` passed when hooks were skipped or unavailable
- [x] Targeted behavior tests pass for the current change set, or tests
are marked not applicable above — command/result or justification:
Repository scans found no remaining NVIDIA#6245 Markdown/MDX or recorded
timing strings; `npm run test:projects:check` reports 1,328 files
disjoint across 8 projects.
- [ ] Applicable broad gate passed — `npm test` for broad
runtime/test-harness changes; `npm run check` for repo-wide
validation/coverage changes — command/result:
- [x] Quality Gates section completed with required justifications or
waivers
- [x] No secrets, API keys, or credentials committed
- [ ] `npm run docs` builds without warnings (doc changes only) —
command passed; Fern reported two advisory warnings, so this remains
intentionally unchecked.
- [ ] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

---
<!-- DCO sign-off is required in this PR description, and every commit
must appear as Verified in GitHub. Run: git config user.name && git
config user.email -->
Signed-off-by: Carlos Villela <cvillela@nvidia.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Removed the test suite README and its related performance notes,
measurement details, results tables, and coverage breakdowns.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v0.0.76 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants