docs(test): remove historical performance snapshot#6422
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe test/README.md file was deleted, removing documentation of the NemoClaw test suite's performance reference, measurement methodology, results tables, and coverage breakdowns. No code or exported entities were changed. Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
E2E Target RecommendationRequired E2E targets: None Full E2E target advisor summaryE2E Target AdvisorBase: Required E2E targets
Optional E2E targets
Relevant changed files
|
PR Review Advisor — No blocking findingsMerge posture: No blocking advisor findings This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
PR Review Advisor (Nemotron Ultra) — No blocking findingsMerge posture: No blocking advisor findings This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
<!-- markdownlint-disable MD041 --> ## Summary Remove the dated NVIDIA#6245 performance snapshot now that the issue is closed. This keeps repository documentation focused on current behavior while retaining historical measurements in Git history, the issue, and PR NVIDIA#6420. ## Related Issue Follow-up cleanup after NVIDIA#6245. ## Changes - Delete `test/README.md`, which contained host-specific timings, historical hotspot classifications, and the completed optimization narrative. - Preserve active `NVIDIA#6245` regression-test suffixes and current Vitest scheduling comments because they still document behavior rather than historical run data. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates <!-- Check exactly one tests line and one docs line. Check other lines when applicable. Add every requested justification or approval reference. --> - [ ] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [x] Tests not applicable — justification: This deletes an unreferenced archival Markdown snapshot and does not change code, test selection, or runtime behavior. - [ ] Docs updated for user-facing behavior changes - [x] Docs not applicable — justification: No user-facing `docs/` content changes; this removes an internal historical test artifact. - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification <!-- Check each applicable item only when supported by the requested evidence. Run targeted tests once per relevant change set and rerun after later edits or hook autofixes that can affect that behavior. Do not rerun hook-covered checks. --> - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: Repository scans found no remaining NVIDIA#6245 Markdown/MDX or recorded timing strings; `npm run test:projects:check` reports 1,328 files disjoint across 8 projects. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) — command passed; Fern reported two advisory warnings, so this remains intentionally unchecked. - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- <!-- DCO sign-off is required in this PR description, and every commit must appear as Verified in GitHub. Run: git config user.name && git config user.email --> Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Removed the test suite README and its related performance notes, measurement details, results tables, and coverage breakdowns. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Remove the dated #6245 performance snapshot now that the issue is closed. This keeps repository documentation focused on current behavior while retaining historical measurements in Git history, the issue, and PR #6420.
Related Issue
Follow-up cleanup after #6245.
Changes
test/README.md, which contained host-specific timings, historical hotspot classifications, and the completed optimization narrative.#6245regression-test suffixes and current Vitest scheduling comments because they still document behavior rather than historical run data.Type of Change
Quality Gates
docs/content changes; this removes an internal historical test artifact.Verification
Verifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm run test:projects:checkreports 1,328 files disjoint across 8 projects.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only) — command passed; Fern reported two advisory warnings, so this remains intentionally unchecked.Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit