-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(security): harden local credential capture #6439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6546c08
fix(security): add one-shot credential helper
cv e4b81c0
docs(security): pin reviewed credential workflow
cv f6d20f1
test(security): linearize credential helper harness
cv a5d8d8b
fix(security): pin credential form descriptor
cv 53cd27f
docs(security): repin credential helper artifact
cv 854a132
fix(security): address credential review findings
cv e84eda7
docs(security): repin reviewed credential artifacts
cv 24837cf
fix(security): sanitize approved command environment
cv 47789c7
docs(security): repin sanitized credential artifacts
cv 0c3f930
fix(security): accept case-insensitive script tags
cv f393bba
fix(security): canonicalize credential child policy
cv b4e6ca6
docs(security): repin reviewed credential artifacts
cv 7868566
fix(security): isolate credential execution profiles
cv 9254855
docs(security): repin isolated credential artifacts
cv 78867a3
test(security): keep credential helper tests linear
cv a413ba3
test(security): clarify generated cleanup marker
cv 22f6ac3
docs(starter-prompt): slim credential capture guidance (#6477)
miyoungc 99f293e
Merge branch 'main' into codex/harden-local-credential-helper
cv bdf3360
Merge branch 'main' into codex/harden-local-credential-helper
cv dd61a30
fix(security): drop ambient credential child environment
cjagwani e5be9d5
docs(security): repin local credential artifacts
cjagwani ec50830
test(dcode): keep image suite within budget
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Env-hardening wording understates the actual behavior.
The helper now inherits zero ambient environment (
sanitizeInheritedChildEnvironmentreturns{}), so the child receives only the execution-profile environment plus explicitly submitted fields. "strips ambient credential and process-control variables" reads as selective stripping and understates the guarantee this prompt asks non-technical users to trust.📝 Suggested wording
📝 Committable suggestion
🤖 Prompt for AI Agents