fix(e2e): repair release gate regressions#6722
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughDocker startup-command recreation now preserves native CDI GPU requests. Slack runtime proof discovery now scans managed OpenClaw npm projects for Slack packages. A gateway auth contract test passes destructured fixtures explicitly. ChangesDocker CDI preservation
Managed Slack package discovery
Gateway auth test contract
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant DockerContainerInspect
participant buildDockerGpuCloneRunArgs
participant RecreatedDockerRun
DockerContainerInspect->>buildDockerGpuCloneRunArgs: provide CDI DeviceRequests
buildDockerGpuCloneRunArgs->>buildDockerGpuCloneRunArgs: extract DeviceIDs
buildDockerGpuCloneRunArgs->>RecreatedDockerRun: append --device arguments
sequenceDiagram
participant resolveOpenClawSlackApiLocation
participant addManagedNpmProjectSlackCandidates
participant ManagedNpmProjectPackageJson
resolveOpenClawSlackApiLocation->>addManagedNpmProjectSlackCandidates: scan managed projects
addManagedNpmProjectSlackCandidates->>ManagedNpmProjectPackageJson: read dependencies
ManagedNpmProjectPackageJson-->>addManagedNpmProjectSlackCandidates: identify `@openclaw/slack`
addManagedNpmProjectSlackCandidates-->>resolveOpenClawSlackApiLocation: register candidate path
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage remains at 96%, unchanged from the branch. TypeScript / code-coverage/cliThe overall coverage in the branch remains at 79%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
PR Review Advisor — No blocking findingsMerge posture: No blocking advisor findings This is an automated review. Required findings need action before merge. Warnings and optional suggestions do not require a response or follow-up. A human maintainer makes the final merge decision. |
Summary
Repairs three deterministic failures found during v0.0.81 release validation. Hermes restart-safe recreation now preserves OpenShell's native CDI GPU attachment, the Slack proof finds the reviewed package in canonical managed npm projects, and the OpenShell auth contract collects under Vitest's fixture parser.
Changes
Driver: cdidevice IDs as Docker--devicearguments during startup-command recreation, without selecting compatibility GPU mode or adding broader privileges.@openclaw/slackone level below OpenClaw's managed npm projects only when the project manifest declares that dependency.The two
rebuild-hermes-stale-baseattempts ended with GitHub's hosted runner losing communication before Vitest exited or uploaded artifacts; the unchanged ordinary rebuild also lost a runner once and passed on retry. Jetson had no runner. Neither result has an evidence-backed repository change in this PR.Type of Change
Quality Gates
Verification
Verifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Bug Fixes
Tests