fix(installer): retain qualified Station DKMS revision#7214
Conversation
Signed-off-by: San Dang <sdang@nvidia.com>
sandl99
added
area: install
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe Station preparation script accepts the qualified DKMS forward revision as retained-compatible, excludes it from APT transactions, and applies readiness-based checks across preparation, verification, reboot, and runtime validation. Tests and documentation cover the updated behavior. ChangesRetained-compatible DKMS support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant run_apply
participant package_state
participant APT
participant verify_host
run_apply->>package_state: classify prerequisite versions
package_state-->>run_apply: exact or retained-compatible readiness
run_apply->>APT: request only missing package transactions
APT-->>run_apply: apply package changes
run_apply->>verify_host: validate accepted packages and runtime state
verify_host-->>run_apply: verification result
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit e130e40 in the TypeScript / code-coverage/cliThe overall coverage in commit e130e40 in the Show a code coverage summary of the most impacted files.
Updated |
|
🌿 Preview your docs: https://nvidia-preview-pr-7214.docs.buildwithfern.com/nemoclaw |
PR Review Advisor — InformationalAdvisor assessment: Informational / high confidence Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: San Dang <sdang@nvidia.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/get-started/dgx-station-preparation.mdx`:
- Around line 58-60: Update the retained-version allowlist documentation around
the “complete generic-Ubuntu package tuple” to explicitly state that a retained
DKMS revision is accepted only when every package in the tuple matches its
qualified value; DKMS-version-only matches must not qualify.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 67ce1079-3865-4c1b-baf5-56afc0deaf5f
📒 Files selected for processing (3)
docs/get-started/dgx-station-preparation.mdxscripts/prepare-dgx-station-host.shtest/install-station-package-transaction.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- test/install-station-package-transaction.test.ts
Signed-off-by: San Dang <sdang@nvidia.com>
senthilr-nv
left a comment
senthilr-nv
left a comment
There was a problem hiding this comment.
Reviewed final head 26cf2c9. No blocking findings. The retained DKMS revision is bound to the complete qualified generic-Ubuntu package tuple, excluded from APT mutation, and remains fail-closed for unlisted versions or companion-package drift. Verified 103 focused tests locally; required CI, ShellCheck, CodeQL, and E2E gate are green.
cjagwani
left a comment
cjagwani
left a comment
There was a problem hiding this comment.
Blocking the product-scope gate on exact head 26cf2c9d626694d035f3af6512f371e0b4049ed1; the code/security review itself passed.
Issue #7211 explicitly says it requests a product and compatibility decision and does not establish support, requires ownership and lifecycle for the compatibility policy, has no Project item or release-decision comment, and is not itself targeted to v0.0.89. This PR nonetheless makes dkms=1:3.4.1-1ubuntu1 a canonical retained-compatible Station tuple and documents that behavior as supported.
Please record an explicit maintainer product/compatibility decision covering qualification evidence, tuple ownership, lifecycle/removal criteria, supported Station profiles, security expectations, and hardware validation before this can be approved for merge. Green CI and the existing technical approval do not substitute for that decision.
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
v0.0.89 verification statusAcknowledging @cjagwani's valid product-scope review: this update supplies the requested technical and physical evidence, but does not treat that review as resolved without an explicit maintainer decision. Current head Completed verification:
The required product decision and explicit validation-deferral choice are recorded for maintainer action in #7211. This PR should remain subject to that explicit decision; this status does not claim that the remaining physical pass is complete. |
|
Post-merge physical qualification is complete: PASS on a freshly reprovisioned generic Ubuntu 24.04 ARM64 DGX Station GB300. Immutable source:
Evidence:
No NemoClaw onboarding, OpenShell setup, model download, or inference was run; this qualification was intentionally scoped to host preparation and retained-package behavior. |
<!-- markdownlint-disable MD041 --> ## Summary Add the canonical dated changelog entry for NemoClaw `v0.0.89` before the release plan captures the tag commit. The entry summarizes the user-visible Station preparation, inference, recovery, policy-disclosure, and CLI-containment changes merged since `v0.0.88`. ## Changes - Add `docs/changelog/2026-07-20.mdx` with the exact `## v0.0.89` release heading, parser-safe SPDX comment, summary, and detailed bullets. - Link each shipped theme to the most specific published OpenClaw documentation routes. - Keep internal E2E, advisory-registry, and review-workflow refactors out of the user-facing release summary. Source summary: - #7214, #7241, #7237, #7223, #7204, #7202, #7183, and #7090 -> `docs/changelog/2026-07-20.mdx`: Summarize qualified DGX Station identity, package-state, PackageKit, DKMS, and reboot-handoff fixes. - #7242, #7221, #7186, #7164, and #6874 -> `docs/changelog/2026-07-20.mdx`: Summarize inference endpoint provenance, provider attachment, managed vLLM cleanup and progress, and Ollama selection guidance. - #7225, #7216, #7192, #7136, #7096, and #6910 -> `docs/changelog/2026-07-20.mdx`: Summarize sandbox readiness, recovery guidance, rebuilt model routing, durable Hermes state, and gateway restart behavior. - #7187 -> `docs/changelog/2026-07-20.mdx`: Summarize complete effective messaging-preset egress disclosure before policy mutation. - #7218, #7165, and #7184 -> `docs/changelog/2026-07-20.mdx`: Summarize structured output containment, terminal-safe route display, and Hermes forward cleanup. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [ ] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [x] Tests not applicable — justification: This PR adds release-history prose only; the focused changelog contract test validates its required structure and routes. - [x] Docs updated for user-facing behavior changes - [ ] Docs not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — `mise exec node@22.23.1 -- npx vitest run test/changelog-docs.test.ts` (6 passed). - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — not applicable to this doc-only release entry. - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) — `mise exec node@22.23.1 -- npm run docs` completed with 0 errors and 2 existing site-wide warnings. - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) — the native changelog entry uses the required parser-safe MDX SPDX comment and does not use frontmatter. --- Signed-off-by: Aaron Erickson <aerickson@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Expanded DGX Station installation support for qualified GB300 and OTA-upgraded environments. * Preserved selected inference providers, endpoints, model pins, and tuning settings during sandbox creation and rebuilds. * Improved sandbox recovery by validating availability and stability before restarting services. * Added clearer policy output showing the complete effective messaging egress configuration. * **Bug Fixes** * Hardened status and inference route displays by sanitizing terminal control characters. * Improved Hermes uninstall behavior by stopping detached dashboard forwarding. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
5 participants
Summary
Generic-Ubuntu DGX Station preparation now warns and retains the qualified installed DKMS revision
1:3.4.1-1ubuntu1instead of rejecting it against the clean-host1:3.4.0-1ubuntu1pin. Unknown prerequisite drift still fails closed, and retained DKMS remains outside every APT transaction.Related Issue
Fixes #7211
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpx vitest run --project installer-integration test/install-station-host-preparation.test.ts test/install-station-package-transaction.test.ts --testTimeout=15000(65 passed);npx vitest run --project integration test/install-station-container-coexistence.test.ts --testTimeout=15000(17 passed);npm run test:projects:check;npm run test-size:check.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — not applicable to this focused installer package-state change.npm run docsbuilds without warnings (doc changes only) — completed with 0 errors and 2 existing warnings.Signed-off-by: San Dang sdang@nvidia.com
Summary by CodeRabbit