fix(docker): use host-gateway callbacks on macOS#1516
Merged
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Label |
This was referenced May 22, 2026
johntmyers
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix macOS Docker-backed gateway startup by using Docker's host-gateway callback route instead of trying to bind the Docker VM bridge gateway IP.
Related Issue
Related to #1307
Changes
host_gateway_ipis explicitly configured.host_gateway_ipoverrides.Testing
cargo test -p openshell-driver-docker docker_gateway_routecargo check -p openshell-server --bin openshell-gateway127.0.0.1:17670, registered mTLS CLI gateway, createdmacos-local-test, ranecho openshell-sandbox-ok, and verified cleanupmise run pre-commitpassesrun::tests::http_health_check_supports_plain_http_endpointstest:e2elabel.Checklist