Skip to content

fix(cli): support fixed OIDC callback ports#2375

Closed
afourniernv wants to merge 1 commit into
NVIDIA:mainfrom
afourniernv:fix/oidc-fixed-callback-port
Closed

fix(cli): support fixed OIDC callback ports#2375
afourniernv wants to merge 1 commit into
NVIDIA:mainfrom
afourniernv:fix/oidc-fixed-callback-port

Conversation

@afourniernv

Copy link
Copy Markdown

Summary

Adds an optional fixed loopback callback port for the generic CLI OIDC Authorization Code plus PKCE flow. This lets operators use IdPs that require an exact pre-registered redirect URI.

Related Issue

Supports NVIDIA/NemoClaw#6871. This PR deliberately contains no IdP profile, provider integration, or tenant configuration.

Changes

  • Add OPENSHELL_OIDC_CALLBACK_PORT with validation for a non-zero TCP port.
  • Keep the existing ephemeral loopback callback behavior as the default.
  • Document use with a pre-registered redirect URI.

Testing

  • mise run pre-commit passes.
  • cargo test -p openshell-cli oidc_auth::tests passes, 13 tests.
  • mise run docs passes.
  • E2E tests are not needed for a local CLI callback binding change.

Checklist

  • Follows Conventional Commits.
  • Commits are signed off (DCO).
  • Documentation updated.

Signed-off-by: Alex Fournier <afournier@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant