fix(cli): support fixed OIDC callback ports#2375
Closed
afourniernv wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Alex Fournier <afournier@nvidia.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional fixed loopback callback port for the generic CLI OIDC Authorization Code plus PKCE flow. This lets operators use IdPs that require an exact pre-registered redirect URI.
Related Issue
Supports NVIDIA/NemoClaw#6871. This PR deliberately contains no IdP profile, provider integration, or tenant configuration.
Changes
OPENSHELL_OIDC_CALLBACK_PORTwith validation for a non-zero TCP port.Testing
mise run pre-commitpasses.cargo test -p openshell-cli oidc_auth::testspasses, 13 tests.mise run docspasses.Checklist