fix(supervisor): tailor Landlock rights by inode type#2380
Merged
Conversation
Closes #2218 Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 21, 2026 01:43
Collaborator
|
/ok to test ce3cc87 |
pimlock
approved these changes
Jul 21, 2026
pimlock
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Adding the e2e label, since this has a new E2E test.
|
Label |
drew
enabled auto-merge
July 21, 2026 03:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Landlock
hard_requirementsandbox startup when filesystem policy enrichment adds device files such as/dev/urandom. Rules now use inode-compatible access rights derived from the already-open path descriptor, avoiding both invalid directory-only rights on non-directories and pathname TOCTOU races.Related Issue
Closes #2218
Changes
fstatbefore constructing its rule./dev/urandom.Testing
mise run pre-commitpassesOPENSHELL_E2E_DOCKER_TEST=landlock mise run e2e:dockerincompatible directory-only access-rights ... ReadDirChecklist