-
Notifications
You must be signed in to change notification settings - Fork 774
[PyTorch] Enable fused FP8 block-scaling path in GroupedLinear module #3171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
denera
wants to merge
10
commits into
NVIDIA:main
Choose a base branch
from
denera:pytorch/grouped-linear-fused-fp8bs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4d35142
[Common/PyTorch] Support power-of-2 scales in grouped FP8 block-scali…
denera 3abc77c
[PyTorch] Enable fused grouped FP8 block-scaling path in GroupedLinea…
denera 30317aa
[PyTorch] Enable FP8 block-scaling in GroupedLinear fusible op
denera 2f6c022
[PyTorch] Use persistent workspaces in grouped-tensor GEMM
denera b5a54a9
[PyTorch] Fix grouped FP8 block-scaling CUDA-graph deadlock via per-r…
denera 8554837
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2527884
[PyTorch] Address review: document split-accumulator override, fix st…
denera 34c7b49
[PyTorch] Revert fusible-ops FP8 block-scaling; scope PR to GroupedLi…
denera 363bbf0
[PyTorch] Isolate grouped wgrad cuBLAS workspace by NT layout, not ou…
denera e365a88
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems too much to be honest. We already have cuda graph test that verifies the graph safeness. If it is graph safe, it has to go through the group quantize route. So I dont think, counting the group_quantize calls and verifying is necessary