Fix agentgateway release pin#1476
Conversation
Pin agentgateway charts to v1.3.1 and extend the CRD health check to cover the chart-owned CRDs. Fixes: NVIDIA#1467
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates Estimated code review effort: 2 (Simple) | ~15 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-fix-agentgateway-release-pin.docs.buildwithfern.com/aicr |
Recipe evidence check
Protected recipesRecipes with committed evidence (
Other affected recipes without evidence yet: 26These recipes are affected by this PR but carry no committed evidence pointer, so there is
How to refresh evidenceRun on a cluster matching the recipe's aicr snapshot -o snapshot.yaml
aicr validate \
-r recipes/overlays/<slug>.yaml \
-s snapshot.yaml \
--emit-attestation ./out \
--push ghcr.io/<your-fork>/aicr-evidence
# Copy to the per-source path printed in the emit 'copyTo' hint:
# recipes/evidence/<slug>/<source>/<bundle-digest>.yamlThis gate is warning-only and never blocks merge. See ADR-007 for the trust model. |
yuanchen8911
left a comment
There was a problem hiding this comment.
thanks for the PR, left a few comments. PTAL.
yuanchen8911
left a comment
There was a problem hiding this comment.
cc @danehans
Approving. The re-pin is correct and complete (registry, mixin, BOM, chainsaw assert), and the agentgateway.dev CRD Established asserts close the gap noted in #1221. The CRD-schema mismatch is non-blocking per the thread; follow-up issue to come.
Before merge: please rebase onto current main (the branch is ~90 commits behind and the merge gate will require it), re-run make bom-docs since the BOM has drifted on main, and mark the PR ready for review.
|
Follow-up issue filed: #1646 — chore(recipes): vendor GAIE v1.5.0 CRDs for agentgateway (appProtocol support) |
|
@yuanchen8911 this is still in draft, do you know why? |
Summary
Pin agentgateway and agentgateway-crds to the published agentgateway
v1.3.1release and refresh the generated BOM docs.Motivation / Context
v2.2.1is not an agentgateway release, so inference recipes were pointing at an invalid upstream chart version.Fixes: #1467
Related: #1646
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
The agentgateway CRD health check now also asserts the chart-installed
agentgateway.devCRDs are established.Testing
Also deployed a focused agentgateway bundle to a fresh Kind cluster and verified the controller, inference gateway, Gateway status, service source ranges, and live Chainsaw health checks.
Risk Assessment
Rollout notes: N/A
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info