Skip to content

[libcu++] Use cccl runtime in thrust tests pt 5#9800

Open
pciolkosz wants to merge 2 commits into
NVIDIA:mainfrom
pciolkosz:adopt-cccl-runtime-2800-set5
Open

[libcu++] Use cccl runtime in thrust tests pt 5#9800
pciolkosz wants to merge 2 commits into
NVIDIA:mainfrom
pciolkosz:adopt-cccl-runtime-2800-set5

Conversation

@pciolkosz

Copy link
Copy Markdown
Contributor

#2800 pt 5

@pciolkosz pciolkosz requested a review from a team as a code owner July 10, 2026 23:52
@pciolkosz pciolkosz requested a review from miscco July 10, 2026 23:52
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jul 10, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 460dbf7f-0953-4536-b2ea-e17f20d0194c

📥 Commits

Reviewing files that changed from the base of the PR and between aeaa386 and 7795734.

📒 Files selected for processing (4)
  • thrust/testing/cuda/cccl_runtime_test_helper.cuh
  • thrust/testing/cuda/fill.cu
  • thrust/testing/cuda/sequence.cu
  • thrust/testing/cuda/uninitialized_fill.cu

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved CUDA test validation across fill, sequence, and uninitialized-fill operations.
    • Ensured comparisons correctly support buffers containing types other than int.
    • Improved CUDA stream handling and result verification for more reliable test coverage.

Walkthrough

Changes

CUDA runtime test migration

Layer / File(s) Summary
Runtime assertion type alignment
thrust/testing/cuda/cccl_runtime_test_helper.cuh
Host-side assertion storage now uses the buffer’s value type.
Fill test execution migration
thrust/testing/cuda/fill.cu
Device and stream tests use functor kernels, CCCL buffers, cuda::stream, and runtime assertions.
Sequence test execution migration
thrust/testing/cuda/sequence.cu
Sequence tests replace raw kernels and manual stream management with cuda::launch, CCCL buffers, and stream-based assertions.
Uninitialized-fill test execution migration
thrust/testing/cuda/uninitialized_fill.cu
Uninitialized-fill tests use functor kernels, CCCL buffers, stream synchronization, and runtime assertions, including returned-iterator validation.

Suggested reviewers: ericniebler, caugonnet, davebayer, bernhardmgruber


Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

😬 CI Workflow Results

🟥 Finished in 2h 59m: Pass: 97%/70 | Total: 2d 06h | Max: 2h 59m | Hits: 34%/415435

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant