docs: refresh air-gapped values example#409
Conversation
Signed-off-by: Omri SirComp <omribz156@gmail.com>
Documentation preview |
a-mccarthy
left a comment
There was a problem hiding this comment.
@omribz156 thanks for the contribution! apologies for the delay in the review.
This page is currently using a very old sample file. We should update the sample to be more recent, as it is missing components and formatting.
Updating the version numbers is only part of the updates needed.
| Replace <repo.example.com:port> below with your local image registry URL and port. | ||
|
|
||
| Sample of ``values.yaml`` for GPU Operator v1.9.0: | ||
| Sample ``values.yaml`` override pattern: |
There was a problem hiding this comment.
I think this whole sample is out of date actually, not just the version numbers.
the helm chart values are listed here: https://github.com/NVIDIA/gpu-operator/blob/main/deployments/gpu-operator/values.yaml
There was a problem hiding this comment.
Thanks, updated in e06fe2f. I refreshed the override sample against the current NVIDIA/gpu-operator values.yaml instead of only changing versions: added the newer image-bearing components, fixed the validator/gfd image names, split dcgm from dcgmExporter, and normalized the YAML indentation. Verified with git diff --check, parsed the sample YAML block, and ran the source-truth helper against this doc.
There was a problem hiding this comment.
Small follow-up: the first push missed the required DCO sign-off, so I amended the commit with Signed-off-by and force-pushed with lease. The current commit is 3e8603c with the same doc changes.
Signed-off-by: Omri SirComp <omribz156@gmail.com>
e06fe2f to
3e8603c
Compare
Summary:
v1.7.0rawvalues.yamlfetch with the Helm chart values flow used elsewhere in the GPU Operator docs.values.yaml.Verification:
rg -n "v1\.7\.0|v1\.9\.0|11\.4\.2-base-ubi8|v0\.10\.0-ubi8|2\.3\.1-2\.6\.0|helm show values|Sample ``values.yaml``|<driver-version>" gpu-operator/install-gpu-operator-air-gapped.rstgit diff --checkNotes:
pre-commitorhelmlocally because those CLIs are not installed in this environment.helm show valuesflow is already used in the current GPU Operator docs (getting-started.rstandupgrade.rst).Addresses part of #391.
This was implemented with Codex assistance, with the final diff manually reviewed and kept to the docs page scope.