Skip to content

docs: refresh air-gapped values example#409

Open
omribz156 wants to merge 2 commits into
NVIDIA:mainfrom
omribz156:codex/airgapped-values-refresh
Open

docs: refresh air-gapped values example#409
omribz156 wants to merge 2 commits into
NVIDIA:mainfrom
omribz156:codex/airgapped-values-refresh

Conversation

@omribz156

Copy link
Copy Markdown

Summary:

  • Replace the old v1.7.0 raw values.yaml fetch with the Helm chart values flow used elsewhere in the GPU Operator docs.
  • Remove fixed GPU Operator v1.9-era component tags from the air-gapped sample and show a version-neutral local registry override pattern.
  • Add guidance to keep image and version values from the selected chart's values.yaml.

Verification:

  • rg -n "v1\.7\.0|v1\.9\.0|11\.4\.2-base-ubi8|v0\.10\.0-ubi8|2\.3\.1-2\.6\.0|helm show values|Sample ``values.yaml``|<driver-version>" gpu-operator/install-gpu-operator-air-gapped.rst
  • git diff --check

Notes:

  • I could not run pre-commit or helm locally because those CLIs are not installed in this environment.
  • The helm show values flow is already used in the current GPU Operator docs (getting-started.rst and upgrade.rst).

Addresses part of #391.

This was implemented with Codex assistance, with the final diff manually reviewed and kept to the docs page scope.

Signed-off-by: Omri SirComp <omribz156@gmail.com>
@a-mccarthy a-mccarthy self-assigned this Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Documentation preview

https://nvidia.github.io/cloud-native-docs/review/pr-409

@a-mccarthy a-mccarthy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omribz156 thanks for the contribution! apologies for the delay in the review.

This page is currently using a very old sample file. We should update the sample to be more recent, as it is missing components and formatting.

Updating the version numbers is only part of the updates needed.

Replace <repo.example.com:port> below with your local image registry URL and port.

Sample of ``values.yaml`` for GPU Operator v1.9.0:
Sample ``values.yaml`` override pattern:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this whole sample is out of date actually, not just the version numbers.

the helm chart values are listed here: https://github.com/NVIDIA/gpu-operator/blob/main/deployments/gpu-operator/values.yaml

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated in e06fe2f. I refreshed the override sample against the current NVIDIA/gpu-operator values.yaml instead of only changing versions: added the newer image-bearing components, fixed the validator/gfd image names, split dcgm from dcgmExporter, and normalized the YAML indentation. Verified with git diff --check, parsed the sample YAML block, and ran the source-truth helper against this doc.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small follow-up: the first push missed the required DCO sign-off, so I amended the commit with Signed-off-by and force-pushed with lease. The current commit is 3e8603c with the same doc changes.

Signed-off-by: Omri SirComp <omribz156@gmail.com>
@omribz156 omribz156 force-pushed the codex/airgapped-values-refresh branch from e06fe2f to 3e8603c Compare July 7, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants