Repository navigation
fix(cuda-oxide-mlir-export): saturate float to int casts - #1655
Open
Rachit2323 wants to merge 1 commit into
Open
Rachit2323 wants to merge 1 commit into
Rachit2323 wants to merge 1 commit into
Conversation
Fixes NVIDIA#1642. Signed-off-by: Rachit2323 <atreyrachit23@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1642.
Summary
On the cutlass-mlir backend,
300.0 as u8wasn't clamped to 255 like it is in Rust. The exporter was emitting plainarith.fptosi/arith.fptoui, and those are undefined when the value is out of range. Now it uses the.satintrinsics, the same as mir-lower does.Changes
mir/core.rs: float to int casts go throughllvm.call_intrinsicwithllvm.fptosi.sat/llvm.fptoui.sat. I copied the pattern from the saturating add/sub inmir/memory.rs.Testing
No GPU on my machine, so I couldn't run a kernel.
The new tests fail on main and pass with this.
cargo test -p cuda-oxide-mlir-export, fmt and clippy are clean.I also pushed the MLIR through mlir-translate and llc by hand. The PTX has the clamp now, and it didn't before.
just check(can't run it, no CUDAcargo oxide run(no GPU)New example (not needed)
Checklist
git commit -s)