fix: Hint at api.name config when 404 source mismatches CLI config#537
fix: Hint at api.name config when 404 source mismatches CLI config#537kfelternv wants to merge 2 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
WalkthroughThis PR adds diagnostic guidance for API configuration mismatches. The ChangesAPI name mismatch hint feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-05-15 19:12:19 UTC | Commit: 23cabcd |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
thossain-nv
left a comment
There was a problem hiding this comment.
@kfelternv Could this confuse those who are using /forge?
thossain-nv
left a comment
There was a problem hiding this comment.
So the API will return a json structure for 404 responses where the source field is set to the API name, we could just hint that?
4bb126d to
4b0f580
Compare
thossain-nv
left a comment
There was a problem hiding this comment.
Looks good, thanks for the changes @kfelternv
Based on a few bug reports, adding a small hint to direct users to the api.name configuration option would help debug 404s when using the cli with nico rest