Skip to content

change: update NICo to use RMS fw object management API#1861

Open
anunna0 wants to merge 17 commits into
NVIDIA:mainfrom
anunna0:RMS_fw_object_management
Open

change: update NICo to use RMS fw object management API#1861
anunna0 wants to merge 17 commits into
NVIDIA:mainfrom
anunna0:RMS_fw_object_management

Conversation

@anunna0
Copy link
Copy Markdown
Contributor

@anunna0 anunna0 commented May 21, 2026

Description

Summary

Migrates firmware-object based firmware updates to RMS/NICO’s SOT JSON apply flow.

Changes

  • Removes the NICo firmware-object management surface from Forge/admin CLI.
  • Extends component firmware update requests with access_token and force_update.
  • Routes compute tray, switch, and rack firmware updates through rack maintenance when state-controller paths are enabled.
  • Uses RMS ApplyFirmwareObjectFromJSON for SOT JSON parsing, artifact download, and firmware update submission.
  • Keeps direct component-manager firmware update paths for non-state-controller flows.
  • Leaves power shelf SOT JSON updates unimplemented for now.
  • Skips implicit rack firmware update when no SOT JSON is configured.
  • Rejects explicit firmware-upgrade maintenance requests without SOT JSON/access token.
  • Requires rack profile hardware class before applying SOT JSON firmware, avoiding unsafe prod assumption

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Related Issues (Optional)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 21, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@anunna0 anunna0 marked this pull request as ready for review May 21, 2026 08:01
@anunna0 anunna0 requested a review from a team as a code owner May 21, 2026 08:01
@anunna0 anunna0 force-pushed the RMS_fw_object_management branch from 577bbe7 to afb6587 Compare May 21, 2026 18:09
Copy link
Copy Markdown

@amit-pabalkar amit-pabalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from all the renaming cleanup that we had planned for and agreed upon to in the NICo Firmware Interface document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants