fix(installer) Set proper version metadata for local/dev installs#70
Draft
ryanheffernan wants to merge 14 commits into
Draft
fix(installer) Set proper version metadata for local/dev installs#70ryanheffernan wants to merge 14 commits into
ryanheffernan wants to merge 14 commits into
Conversation
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughInstaller version tags now flow into Helm app version values, UI launch validation, and Nautobot build arguments. The installer config, schema pruning, and tests were updated to carry the tag through. ChangesVersion and image tag propagation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
ryanheffernan
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@installer/tests/test_deployer.py`:
- Around line 687-694: This test is relying on the
fallback-from-config.images.tag path in _build_images(), but it will be bypassed
if NAUTOBOT_APP_OVERLAYS_VERSION or NAUTOBOT_NV_CONFIG_MANAGER_VERSION is
already set in the process environment. Update the test setup around the
_build_images-related monkeypatches to explicitly clear or unset both Nautobot
version overrides so the test remains deterministic and continues to exercise
the intended fallback behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3c56af78-5012-4dfd-a260-98b477a650ab
📒 Files selected for processing (11)
build/nautobot.Dockerfiledeploy/helm/templates/ui.yamldeploy/helm/values.yamlinstaller/src/nv_config_manager_installer/air_sim/installer_config.pyinstaller/src/nv_config_manager_installer/deployer.pyinstaller/src/nv_config_manager_installer/helm_values.pyinstaller/src/nv_config_manager_installer/schema.pyinstaller/tests/air_sim/test_installer_config.pyinstaller/tests/test_deployer.pyinstaller/tests/test_helm_values.pyinstaller/tests/test_schema.py
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Collaborator
Author
|
/ok to test 1a114e7 |
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Collaborator
Author
|
/ok to test 112bff4 |
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
Signed-off-by: rheffernan <rheffernan@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix local/dev installs so the displayed and installed release metadata matches the intended release tag.
global.appVersionfrom the installer image tag so the UI/API health config reportsx.y.z-rc.ainstead of a local content hash.nautobot-app-overlaysno longer falls back to an older version.Validation
Passing Kind Integration run:
https://github.com/NVIDIA/nv-config-manager/actions/runs/28248622074
Checklist
CONTRIBUTING.md.docs screenshots, or Helm/rendered outputs.
Summary by CodeRabbit
Summary
appVersion, preferring a configured app version with sensible fallbacks.tagwhen provided.